Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed behavior in Configuration Assessment when changing API #6770

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fixed behavior in Configuration Assessment when changing API #6770

merged 2 commits into from
Jun 13, 2024

Conversation

jbiset
Copy link
Member

@jbiset jbiset commented Jun 13, 2024 •
edited
Loading

Description

This PR fixes rendering when changing the API in Configuration Assessment when you have an agent pinned.

Issues Resolved

Evidence

evidence.webm

Test

  • Navigate to Configuration Assessment.
  • Pin an agent.
  • Go to Home -> Overview
  • Go to Configuration Assessment.
  • Change the API.
  • Check that the agent selection screen appears in Configuration Assessment.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@jbiset jbiset self-assigned this Jun 13, 2024
@jbiset jbiset linked an issue Jun 13, 2024 that may be closed by this pull request
Changing API in Configuration Assessment redirects to Home overview #6763
Closed
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.17% ( 3980 / 32702 )
Branches 8.11% ( 1743 / 21478 )
Functions 11.67% ( 940 / 8052 )
Lines 12.36% ( 3878 / 31373 )

@chantal-kelm chantal-kelm self-requested a review June 13, 2024 14:06
@JuanGarriuz JuanGarriuz self-requested a review June 13, 2024 14:19
@JuanGarriuz
Copy link
Member

Test 🟢

Evidence

image
image
image
image

JuanGarriuz
JuanGarriuz approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

chantal-kelm
chantal-kelm approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grabacion.de.pantalla.2024-06-13.a.la.s.11.38.36.a.m.mov

@asteriscos asteriscos merged commit 3c7df36 into 4.9.0 Jun 13, 2024
4 checks passed
@asteriscos asteriscos deleted the bug/change-api-in-configuration-assessment branch June 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@chantal-kelm chantal-kelm chantal-kelm approved these changes

Assignees

@jbiset jbiset

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing API in Configuration Assessment redirects to Home overview
4 participants
@jbiset @JuanGarriuz @chantal-kelm @asteriscos