Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index pattern on the filters of home KPI links #6777

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Index pattern on the filters of home KPI links #6777

merged 2 commits into from
Jun 19, 2024

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jun 17, 2024 •
edited
Loading

Description

This pull request fixes the hardcoded value of index pattern on the filters of home KPI links.

Side changes:

  • Fix a problem in the home KPI links when using a index pattern with different title and id.

Issues Resolved

#6776

Evidence

image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors ⚫ ⚫ ⚫
With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors ⚫ ⚫ ⚫

Details

⚫ With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Jun 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.94% ( 187 / 893 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.14% ( 184 / 870 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.3% ( 4278 / 34779 )
Branches 8.31% ( 1938 / 23294 )
Functions 11.63% ( 964 / 8284 )
Lines 12.48% ( 4168 / 33383 )

@Desvelao Desvelao marked this pull request as ready for review June 17, 2024 12:37
@Desvelao Desvelao linked an issue Jun 17, 2024 that may be closed by this pull request
Home overview KPI's link don't work with custom index-pattern #6776
Closed
@asteriscos
Copy link
Member

asteriscos commented Jun 17, 2024 •
edited
Loading

Test Chrome
With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors 🟢
With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors 🟢

Details

🟢 With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors

Chrome - 🟢

image

image

🟢 With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors

Chrome - 🟢

image

image

asteriscos
asteriscos approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

jbiset
jbiset reviewed Jun 19, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
jbiset
jbiset approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI 🟢

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors 🟢 🟢 ⚫
With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors 🟢 🟢 ⚫

Details

🟢 With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors

Chrome - 🟢

image

image

Firefox - 🟢

image

image

Safari - ⚫

🟢 With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors

Chrome - 🟢

image

image

Firefox - 🟢

image

image

Safari - ⚫

@Machi3mfl
Copy link
Member

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors 🟢 ⚫ ⚫
With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors 🟢 ⚫ ⚫

Details

🟢 With an index pattern with the same title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors

Chrome - 🟢

Screenshot 2024-06-19 at 12 25 34 Screenshot 2024-06-19 at 12 26 13

Firefox - ⚫

Safari - ⚫

🟢 With an index pattern with a different title and ID, go to Home > Overview, the KPI links should display and redirect correctly to the Discover app and the filters should be applied without errors

Chrome - 🟢

Screenshot 2024-06-19 at 12 24 00 Screenshot 2024-06-19 at 12 24 46

Firefox - ⚫

Safari - ⚫

Machi3mfl
Machi3mfl approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CR: ✅
Test: ✅

@asteriscos asteriscos merged commit 29c9758 into 4.8.1 Jun 19, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/6776-home-kpi-link-filters-index-pattern branch June 19, 2024 15:35
@asteriscos asteriscos mentioned this pull request Jul 9, 2024
Closed
1 task
@rafprzybysz rafprzybysz mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbiset jbiset jbiset approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@asteriscos asteriscos Awaiting requested review from asteriscos

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home overview KPI's link don't work with custom index-pattern
4 participants
@Desvelao @asteriscos @Machi3mfl @jbiset