Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match colors related to severity levels on the vulnerabilities detection dashboard #6793

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jun 20, 2024

Description

This pull request defines the colors related to vulnerability severity levels on the dashboard of Vulnerability Detection application.

Issues Resolved

#6779

Evidence

image
image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With vulnerabilities states data, go to Vulnerability Detection > Dashboard and ensure the metrics related to severity levels are sharing the colors with the Vulnerabilities by year of publication visualization
The color of metric visualization of High and Medium should have interchanged. Final result: High (orange/yellow tone), Medium (blue tone)

Details

⚫ With vulnerabilities states data, go to Vulnerability Detection > Dashboard and ensure the metrics related to severity levels are sharing the colors with the Vulnerabilities by year of publication visualization

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ The color of metric visualization of High and Medium should have interchanged. Final result: High (orange/yellow tone), Medium (blue tone)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Jun 20, 2024
@Desvelao Desvelao marked this pull request as ready for review June 20, 2024 12:05
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.94% ( 187 / 893 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.14% ( 184 / 870 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.3% ( 4278 / 34780 )
Branches 8.31% ( 1938 / 23294 )
Functions 11.63% ( 964 / 8284 )
Lines 12.48% ( 4168 / 33384 )

@JuanGarriuz JuanGarriuz self-requested a review June 20, 2024 14:11
@JuanGarriuz
Copy link
Member

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With vulnerabilities states data, go to Vulnerability Detection > Dashboard and ensure the metrics related to severity levels are sharing the colors with the Vulnerabilities by year of publication visualization 🟢
The color of metric visualization of High and Medium should have interchanged. Final result: High (orange/yellow tone), Medium (blue tone) 🟢

Details

🟢 With vulnerabilities states data, go to Vulnerability Detection > Dashboard and ensure the metrics related to severity levels are sharing the colors with the Vulnerabilities by year of publication visualization

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 The color of metric visualization of High and Medium should have interchanged. Final result: High (orange/yellow tone), Medium (blue tone)

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI 🟢

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With vulnerabilities states data, go to Vulnerability Detection > Dashboard and ensure the metrics related to severity levels are sharing the colors with the Vulnerabilities by year of publication visualization 🟢 🟢
The color of metric visualization of High and Medium should have interchanged. Final result: High (orange/yellow tone), Medium (blue tone) 🟢 🟢

Details

🟢 With vulnerabilities states data, go to Vulnerability Detection > Dashboard and ensure the metrics related to severity levels are sharing the colors with the Vulnerabilities by year of publication visualization

Chrome - 🟢

image

image

Firefox - 🟢

image

image

Safari - ⚫

🟢 The color of metric visualization of High and Medium should have interchanged. Final result: High (orange/yellow tone), Medium (blue tone)

Chrome - 🟢

image

image

Firefox - 🟢

image

image

Safari - ⚫

@Desvelao Desvelao merged commit 39e534b into 4.8.1 Jun 26, 2024
5 checks passed
@Desvelao Desvelao deleted the bug/6779-vulnerability-severity-colors-dashboard branch June 26, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerability dashboard KPI's colors don't reflect the severity properly
3 participants