Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear session button text is displayed in full #6871

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Clear session button text is displayed in full #6871

merged 4 commits into from
Jul 26, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jul 25, 2024 •
edited
Loading

Description

The clear session button in the ruleset test view now displays the complete text.

Issues Resolved

Evidence

image

Test

  1. Navigate to 'Ruleset test'
  2. See the button

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Jul 25, 2024
@yenienserrano yenienserrano linked an issue Jul 25, 2024 that may be closed by this pull request
The clear session button in the ruleset test section is cut off. #6870
Closed
@chantal-kelm chantal-kelm self-requested a review July 25, 2024 16:55
chantal-kelm
chantal-kelm approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

image

jbiset
jbiset approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI: 🟢

Evidence

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.63% ( 3989 / 29246 )
Branches 9.1% ( 1744 / 19159 )
Functions 13.36% ( 943 / 7057 )
Lines 13.82% ( 3886 / 28110 )

@Desvelao
Copy link
Member

I do not like the entry on the changelog, but I will merge anyways. This could be reviewed later.

@Desvelao Desvelao merged commit 6123462 into 4.9.0 Jul 26, 2024
5 checks passed
@Desvelao Desvelao deleted the bug/6870-the-clear-session-button-in-the-ruleset-test-section-is-cut-off branch July 26, 2024 10:04
@asteriscos asteriscos mentioned this pull request Aug 5, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@jbiset jbiset jbiset approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The clear session button in the ruleset test section is cut off.
4 participants
@yenienserrano @Desvelao @jbiset @chantal-kelm