Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added consistency between url and Endpoint groups view #6890

Merged

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jul 30, 2024

Description

Added URL control to the groups view to know by URL when a group is selected and not. And fixes back button problems when navigating from an agent's configuration.

The name of the selected group is added to the breadcrumb

Issues Resolved

Evidence

Screen.Recording.2024-07-30.at.9.47.09.PM.mov

Test

  1. Navigate to 'Endpoints summary'
  2. Click on an agent
  3. Click on Configuration
  4. Click on one of the groups
  5. Press the back button of the browser
  6. Navigate in the same view of the group and it has to make sense with the URL

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Jul 30, 2024
@yenienserrano yenienserrano linked an issue Jul 30, 2024 that may be closed by this pull request
@Machi3mfl Machi3mfl self-requested a review July 31, 2024 10:57
Machi3mfl
Machi3mfl previously approved these changes Jul 31, 2024
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screen.Recording.2024-07-31.at.08.50.41.mov

Note

The environment used is configured with an imposter server because of that, the title of the group details always says "default" but the URL and browser back button behavior works as expected.

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Peek 2024-07-31 19-07

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.67% ( 4003 / 29267 )
Branches 9.12% ( 1747 / 19143 )
Functions 13.36% ( 945 / 7070 )
Lines 13.86% ( 3900 / 28133 )

@asteriscos asteriscos merged commit 6035f0e into 4.9.0 Jul 31, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/6887-selected-group-view-state-is-inconsistent-in-the-url branch July 31, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected group view state is inconsistent in the URL
3 participants