Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed always disabled property from Active response #6901

Conversation

JuanGarriuz
Copy link
Member

Description

The disabled render was removed and the description of Active response > Active response was changed.

Issues Resolved

Evidence

image

Test

  • Go to Settings > Active Response. Check that the description is according.
  • Go to Settings > Active Response. The status of this active response mustn't be rendered.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz linked an issue Aug 8, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Main plugin code coverage (Jest) test % values
Statements 13.64% ( 3989 / 29231 )
Branches 9.1% ( 1744 / 19153 )
Functions 13.35% ( 943 / 7063 )
Lines 13.83% ( 3886 / 28093 )

@Machi3mfl Machi3mfl self-requested a review August 9, 2024 16:59
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screenshot 2024-08-09 at 14 19 53

@yenienserrano yenienserrano self-requested a review August 12, 2024 11:01
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

@asteriscos asteriscos merged commit 5360fa7 into 4.9.1 Aug 12, 2024
5 checks passed
@asteriscos asteriscos deleted the fix/6801-fixed-always-yes-disabled-property-from-active-response branch August 12, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active response displays wrong status
4 participants