Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed windows-agent-deployment command #6905

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

JuanGarriuz
Copy link
Member

Description

The windows-agent-deployment command uses ${env.tmp} instead of $env:tmp. Then the pull changes the command.

Issues Resolved

Evidence

image

Invoke-WebRequest -Uri https://packages.wazuh.com/4.x/windows/wazuh-agent-4.9.1-1.msi -OutFile $env:tmp\wazuh-agent; msiexec.exe /i $env:tmp\wazuh-agent /q WAZUH_MANAGER='0' 

Test

Go to Endpoints summary > Deploy new agent. Mark Windows deployment and check that the command in step 4 uses $env:tmp instead of ${env.tmp}

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz linked an issue Aug 12, 2024 that may be closed by this pull request
@JuanGarriuz JuanGarriuz self-assigned this Aug 12, 2024
@yenienserrano yenienserrano self-requested a review August 12, 2024 11:31
yenienserrano
yenienserrano previously approved these changes Aug 12, 2024
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.64% ( 3989 / 29231 )
Branches 9.1% ( 1744 / 19153 )
Functions 13.35% ( 943 / 7063 )
Lines 13.83% ( 3886 / 28093 )

@Machi3mfl Machi3mfl self-requested a review August 12, 2024 12:14
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screenshot 2024-08-12 at 13 28 35

@asteriscos asteriscos merged commit 2f01411 into 4.9.1 Aug 13, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/6518-fix-windows-agent-deployment-command branch August 13, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows deployment command is broken
4 participants