Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an error sending payload parameters as arrays on the Dev Tools application #6908

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Aug 14, 2024

Description

This pull request fixes a problem sending payload parameters as arrays on the Dev Tools application.

Issues Resolved

#6899

Evidence

image

Test

Legend:
⚫: none
🟒: pass
🟑: warning
πŸ”΄: fail
βšͺ: not applicable

UI

Test Chrome Firefox Safari
Go to Server management > Dev Tools and run the following request POST /events {"events": ["Test"]} and should not give an error. Use a real manager ⚫ ⚫ ⚫

Details

⚫ Go to Server management > Dev Tools and run the following request POST /events {"events": ["Test"]} and should not give an error. Use a real manager

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Aug 14, 2024
@Desvelao Desvelao changed the title Fixed error sending events from Dev Tools application Fixed an error sending payload parameter as arrays on Dev Tools application Aug 14, 2024
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@Desvelao Desvelao changed the title Fixed an error sending payload parameter as arrays on Dev Tools application Fixed an error sending payload parameters as arrays on the Dev Tools application Aug 14, 2024
@Desvelao Desvelao linked an issue Aug 14, 2024 that may be closed by this pull request
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.65% ( 3989 / 29222 )
Branches 9.11% ( 1744 / 19140 )
Functions 13.35% ( 943 / 7062 )
Lines 13.83% ( 3886 / 28084 )

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@yenienserrano yenienserrano self-requested a review August 14, 2024 10:29
@JuanGarriuz JuanGarriuz self-requested a review August 14, 2024 10:42
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

image

LGTM!!

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟒
Test: 🟒

image

@Desvelao Desvelao merged commit 2554e18 into 4.9.1 Aug 14, 2024
5 checks passed
@Desvelao Desvelao deleted the fix/6899-cannot-post-events-on-devtools branch August 14, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot POST events by using DevTools
3 participants