Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the registration id of the setting application #6938

Merged

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Aug 21, 2024

Description

In opensearch 2.16.0 compatibility they add the option to have a new menu, and because of this change new plugins were registered that conflict with ours so we had to change the settings id.

Issues Resolved

Evidence

image

Test

Using OSD 2.16.0 it should work as expected.
the url of Server management> Settings should be /app/dashboards-settings

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano linked an issue Aug 21, 2024 that may be closed by this pull request
@yenienserrano yenienserrano self-assigned this Aug 21, 2024
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.59% ( 4016 / 29532 )
Branches 9.09% ( 1755 / 19300 )
Functions 13.31% ( 947 / 7110 )
Lines 13.77% ( 3914 / 28416 )

@yenienserrano yenienserrano changed the title Vhange the registration id of the setting application Change the registration id of the setting application Aug 21, 2024
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢
CR 🟢

image
image

LGTM

@chantal-kelm chantal-kelm self-requested a review August 22, 2024 16:23
@Tostti Tostti merged commit 977a347 into 4.10.0 Aug 22, 2024
5 checks passed
@Tostti Tostti deleted the bug/6920-change-the-registration-id-of-the-setting-application branch August 22, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the registration ID of the setting application
3 participants