Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed agent RBAC filters from dashboard queries #6945

Merged
merged 14 commits into from
Sep 2, 2024

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Aug 26, 2024

Description

Remove all use of RBAC filters such as agents allowed.

Closes #6943

Remove allowed agents filters on data source

Before

Screenshot 2024-08-26 at 11 51 05

After

Screenshot 2024-08-26 at 11 52 53

Remove allowed agents state from redux appStateReducers

Note

This method is placed on WzAuthorization and is used on every login.
This adds the allowed agent's list on the app state

Before

Screenshot 2024-08-26 at 12 28 01
Screen.Recording.2024-08-26.at.12.30.00.mov

After

Screenshot 2024-08-26 at 12 33 33

Remove allowed agents filters on reporting (wz-reporting)

Note

extendedInformation

Before

Screenshot 2024-08-26 at 15 58 21

After

Screenshot 2024-08-26 at 15 51 03

Note

Test all module reports

Screen.Recording.2024-08-27.at.15.54.57.mov

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl marked this pull request as ready for review August 27, 2024 18:56
@Machi3mfl Machi3mfl changed the title Remove allowed agents filter in data source Remove allowed agents filter Aug 27, 2024
@asteriscos asteriscos changed the base branch from 4.9.0 to 4.10.0 August 28, 2024 09:03
@Desvelao Desvelao linked an issue Aug 29, 2024 that may be closed by this pull request
@JuanGarriuz JuanGarriuz self-requested a review August 30, 2024 06:58
JuanGarriuz
JuanGarriuz previously approved these changes Aug 30, 2024
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

Grabacion.2024-08-22.105042.mp4

LGTM!!

@jbiset jbiset self-requested a review August 30, 2024 14:01
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟡

There are quite a few changes in the CHANGELOG that are not known to be correct because nothing is mentioned in the PR about them.
The change in this PR is not visible in the CHANGELOG

Test UI: 🟢

Remove allowed agents filters on data source 🟢

image

Remove allowed agents state from redux appStateReducers 🟢

image

Remove allowed agents filters on reporting (wz-reporting) 🟢

evidence_report.webm

@Machi3mfl Machi3mfl changed the title Remove allowed agents filter Remove agent RBAC filters from dashboard queries Sep 2, 2024
@Machi3mfl Machi3mfl changed the title Remove agent RBAC filters from dashboard queries Removed agent RBAC filters from dashboard queries Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Main plugin code coverage (Jest) test % values
Statements 13.57% ( 4004 / 29488 )
Branches 9.07% ( 1749 / 19269 )
Functions 13.29% ( 944 / 7100 )
Lines 13.75% ( 3902 / 28374 )

Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@asteriscos asteriscos merged commit 60dcc23 into 4.10.0 Sep 2, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/6943-remove-allowed-agents-rbac-filters branch September 2, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove agent RBAC filters from dashboard queries
4 participants