Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of column in Vulnerabilities Detection > Events table #6949

Merged

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Aug 29, 2024

Description

This pull request changes the order of the column in Vulnerabilities Detection > Events table.

Side changes:

  • Add the status property to the vulnerabilities detection sample alerts to let the render on the Vulnerabilities Detection > Events table.

Issues Resolved

#6947

Evidence

image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
With alerts of Vulenrabilities detection, go to Vulnerabilities Detection > Events table and check the column order is: timestam, agent.name data.vulnerability.cve, data.vulnerability.severity, data.vulnerability.package.name, data.vulnerability.package.version, data.vulnerability.status

Details

⚫ With alerts of Vulenrabilities detection, go to Vulnerabilities Detection > Events table and check the column order is: timestam, agent.name data.vulnerability.cve, data.vulnerability.severity, data.vulnerability.package.name, data.vulnerability.package.version, data.vulnerability.status

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

- Add status property to the sample data of vulnerabilities detection alerts
  to let the render of the expected columns in the
  vulnerabilities detection > events table
@Desvelao Desvelao self-assigned this Aug 29, 2024
@Desvelao Desvelao marked this pull request as ready for review August 29, 2024 09:54
@Desvelao Desvelao linked an issue Aug 29, 2024 that may be closed by this pull request
JuanGarriuz
JuanGarriuz previously approved these changes Aug 29, 2024
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

image

asteriscos
asteriscos previously approved these changes Aug 29, 2024
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

@chantal-kelm chantal-kelm self-requested a review August 29, 2024 10:13
chantal-kelm
chantal-kelm previously approved these changes Aug 29, 2024
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de pantalla 2024-08-29 a la(s) 7 13 43 a  m

@Desvelao Desvelao dismissed stale reviews from chantal-kelm, asteriscos, and JuanGarriuz via f66bc8b August 29, 2024 10:20
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.59% ( 4016 / 29541 )
Branches 9.08% ( 1755 / 19313 )
Functions 13.31% ( 947 / 7111 )
Lines 13.76% ( 3914 / 28425 )

@asteriscos asteriscos merged commit 440473b into 4.9.0 Aug 29, 2024
5 checks passed
@asteriscos asteriscos deleted the change/6947-order-vulnerabilities-detection-events-columns branch August 29, 2024 10:30
@Desvelao
Copy link
Member Author

data.vulnerability.status

The screenshot has not include the data.vulnerability.status. I was reviewing this with @chantal-kelm and the documents should contain that field and the index pattern fields should be refreshed, else the column could not be displayed as your screenshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default columns in vulnerabilities events
4 participants