Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve intelligence flyout details readability #6954

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Improve intelligence flyout details readability #6954

merged 3 commits into from
Sep 2, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Sep 2, 2024 •
edited by Desvelao
Loading

Description

The description in the MITRE ATT&CK -> Intelligence -> details flyout get darker

Issues Resolved

Evidence

Before

image
image

After

image
image

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Sep 2, 2024
@JuanGarriuz JuanGarriuz linked an issue Sep 2, 2024 that may be closed by this pull request
MITRE ATT&CK Intelligence flyout text is too light #6951
Closed
@JuanGarriuz
Copy link
Member Author

I have removed the property that lightened the font color. If a darker shade is desired, it can be added in a later commit.

@Desvelao
Copy link
Member

Desvelao commented Sep 2, 2024

Test

image

Tostti
Tostti reviewed Sep 2, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Tostti
Tostti previously approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢

image

CR 🟢

LGTM

@JuanGarriuz JuanGarriuz requested a review from Tostti September 2, 2024 09:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Main plugin code coverage (Jest) test % values
Statements 13.59% ( 4016 / 29532 )
Branches 9.09% ( 1755 / 19300 )
Functions 13.31% ( 947 / 7110 )
Lines 13.77% ( 3914 / 28416 )

Desvelao
Desvelao approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tostti Tostti merged commit 4494d16 into 4.9.1 Sep 2, 2024
5 checks passed
@Tostti Tostti deleted the feat/6951-make-intelligence-flyout-details-darker branch September 2, 2024 10:12
@asteriscos asteriscos mentioned this pull request Sep 23, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

@Desvelao Desvelao Desvelao approved these changes

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MITRE ATT&CK Intelligence flyout text is too light
3 participants
@JuanGarriuz @Desvelao @Tostti