Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed inventory vulnerabilities references to links #6960

Merged
merged 13 commits into from
Sep 11, 2024
Merged

Changed inventory vulnerabilities references to links #6960

merged 13 commits into from
Sep 11, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Sep 4, 2024 •
edited
Loading

Description

This pull converts Vulnerability Detector reference fields into links.
Additionally, the vulnerability injector script is modified to occasionally add 2 links.

Issues Resolved

Evidence

image

Test

Go to Vulnerability Detection > Inventory, and select vulnerability.reference columns and check links are functional

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Sep 4, 2024
@JuanGarriuz JuanGarriuz linked an issue Sep 4, 2024 that may be closed by this pull request
Convert Vulnerability Detector references fields into hyperlinks #6784
Closed
@Machi3mfl Machi3mfl self-requested a review September 4, 2024 12:33
Machi3mfl
Machi3mfl previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screenshot 2024-09-04 at 11 37 32
Screen.Recording.2024-09-04.at.11.37.37.mov

@yenienserrano yenienserrano self-requested a review September 5, 2024 11:08
yenienserrano
yenienserrano previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@JuanGarriuz JuanGarriuz dismissed stale reviews from yenienserrano and Machi3mfl via fb0de53 September 5, 2024 12:31
yenienserrano
yenienserrano previously approved these changes Sep 5, 2024
View reviewed changes
Machi3mfl
Machi3mfl previously approved these changes Sep 5, 2024
View reviewed changes
guidomodarelli
guidomodarelli previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 CR
🟢 Test

image

image

@Desvelao
Copy link
Member

Desvelao commented Sep 5, 2024

Test

image
image

Expanded cell
image

asteriscos and others added 2 commits September 6, 2024 11:28
@asteriscos
Bump Wazuh 4.9.2 rev 00 (#6971)
82ce603 
* Bump version to 4.9.2

* Fix changelog
@JuanGarriuz
Add withespace to split
c576a6b
@asteriscos asteriscos changed the base branch from 4.9.1 to 4.9.2 September 6, 2024 10:32
@asteriscos asteriscos changed the base branch from 4.9.2 to 4.9.1 September 6, 2024 14:36
@JuanGarriuz
Copy link
Member Author

image

Added to the vulnerability injector script multiple links

@chantal-kelm chantal-kelm self-requested a review September 10, 2024 19:51
chantal-kelm
chantal-kelm approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.59% ( 4016 / 29540 )
Branches 9.09% ( 1755 / 19304 )
Functions 13.31% ( 947 / 7113 )
Lines 13.77% ( 3914 / 28424 )

@Desvelao Desvelao merged commit 1520c8e into 4.9.1 Sep 11, 2024
10 checks passed
@Desvelao Desvelao deleted the feat/6784-change-inventory-vul-references-to-links branch September 11, 2024 06:57
@asteriscos asteriscos mentioned this pull request Sep 23, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@guidomodarelli guidomodarelli guidomodarelli approved these changes

@yenienserrano yenienserrano yenienserrano left review comments

@Machi3mfl Machi3mfl Machi3mfl left review comments

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Vulnerability Detector references fields into hyperlinks
7 participants
@JuanGarriuz @Desvelao @Machi3mfl @guidomodarelli @yenienserrano @chantal-kelm @asteriscos