Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns-selector in events show firsts the picked columns #6984

Merged

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Sep 10, 2024

Description

The Events tab has a column selector that shows all available columns. Selected columns appear in this selector, ordered alphabetically. This PR moves the selected columns to the beginning.

Additionally, add functionality to the table so that default columns maintain their position even when they are added or removed.

Issues Resolved

Evidence

image

Test

  • Go to any app with event tabs
  • Click on the columns selector and make sure that when a column is selected, it appears before the unselected columns
  • Add and remove columns and check that appears first the default columns

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Sep 10, 2024
@JuanGarriuz JuanGarriuz linked an issue Sep 10, 2024 that may be closed by this pull request
asteriscos
asteriscos previously approved these changes Sep 12, 2024
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Vulnerabilities

Peek 2024-09-12 13-23

GitHub

image

Threat hunting

Peek 2024-09-12 13-31

Peek 2024-09-12 13-32

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.62% ( 4026 / 29557 )
Branches 9.09% ( 1755 / 19304 )
Functions 13.33% ( 949 / 7119 )
Lines 13.79% ( 3924 / 28440 )

@asteriscos asteriscos merged commit d7ee5e8 into 4.9.1 Sep 13, 2024
5 checks passed
@asteriscos asteriscos deleted the enhacement/6978-selected-columns-in-events-show-first-picked branch September 13, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events table must order the selected columns first
3 participants