-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix styles that truncates Discover plugin rows #6989
Merged
Desvelao
merged 4 commits into
4.9.1
from
bug/6976-a-custom-style-truncates-discover-plugin-rows
Sep 12, 2024
Merged
Fix styles that truncates Discover plugin rows #6989
Desvelao
merged 4 commits into
4.9.1
from
bug/6976-a-custom-style-truncates-discover-plugin-rows
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
guidomodarelli
approved these changes
Sep 11, 2024
chantal-kelm
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Desvelao
deleted the
bug/6976-a-custom-style-truncates-discover-plugin-rows
branch
September 12, 2024 06:55
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to remove an unnecessary style that truncates the rows in the Discover plugin. As it is a style from the Wazuh plugin, it also makes the wazuh dashboard inconsistent, because if the user refreshes the page inside the Discover plugin, the style is not loaded.
Issues Resolved
#6976
Evidence
Before
After
Test
Note
The text in Discover may be a little bit truncated as it is a problem that is also present in OpenSearch.
Note
The size of the rows in the flyouts may be a little smaller, but the text should be completely legible
Check List
yarn test:jest