Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styles that truncates Discover plugin rows #6989

Merged

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Sep 11, 2024

Description

This PR aims to remove an unnecessary style that truncates the rows in the Discover plugin. As it is a style from the Wazuh plugin, it also makes the wazuh dashboard inconsistent, because if the user refreshes the page inside the Discover plugin, the style is not loaded.

Issues Resolved

#6976

Evidence

Before
image

After
image

Test

  • Navigate to the discover plugin and confirm that the text is not truncated
  • Verify that there are no broken pages after this change

Note

The text in Discover may be a little bit truncated as it is a problem that is also present in OpenSearch.

Note

The size of the rows in the flyouts may be a little smaller, but the text should be completely legible

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti self-assigned this Sep 11, 2024
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.59% ( 4016 / 29540 )
Branches 9.09% ( 1755 / 19302 )
Functions 13.31% ( 947 / 7113 )
Lines 13.77% ( 3914 / 28424 )

@guidomodarelli
Copy link
Contributor

CR 🟢
Test 🟢

image

@Tostti Tostti linked an issue Sep 11, 2024 that may be closed by this pull request
@chantal-kelm chantal-kelm self-requested a review September 11, 2024 19:28
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

image

@Desvelao Desvelao merged commit ed04fa8 into 4.9.1 Sep 12, 2024
5 checks passed
@Desvelao Desvelao deleted the bug/6976-a-custom-style-truncates-discover-plugin-rows branch September 12, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A custom style truncates Discover plugin rows
4 participants