Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove groups autoformat #6999

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Remove groups autoformat #6999

merged 3 commits into from
Sep 19, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Sep 18, 2024 •
edited
Loading

Description

This pull request removes the autoformat function that implements regular expressions that cause performance issues.

Test

Use these test cases as examples:

Steps

  • Create a new group
  • Copy the configuration file
  • Save the new configuration and reload the group's table
  • Try to edit the configuration file
Test case 🎥

Peek 2024-09-18 20-15

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Sep 18, 2024
guidomodarelli
guidomodarelli approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢
Test 🟢

1553.payload.good.mp4
1553.payload.600k.mp4
1553.a.a.a.a.mp4

@Desvelao
Copy link
Member

🟢 Test

image
image

image
image

image
image

Desvelao
Desvelao approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.79% ( 4069 / 29495 )
Branches 9.15% ( 1765 / 19284 )
Functions 13.45% ( 959 / 7127 )
Lines 13.97% ( 3965 / 28381 )

@asteriscos asteriscos merged commit 2373b8c into 4.9.1 Sep 19, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/internal-1553 branch September 19, 2024 08:37
@asteriscos asteriscos mentioned this pull request Sep 23, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@guidomodarelli guidomodarelli guidomodarelli approved these changes

@chantal-kelm chantal-kelm Awaiting requested review from chantal-kelm

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asteriscos @Desvelao @guidomodarelli