Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style breaks when unpinned an agent in safari #7015

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Style breaks when unpinned an agent in safari #7015

merged 2 commits into from
Sep 26, 2024

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Sep 25, 2024 •
edited
Loading

Description

Style breaks when unpinned an agent in safari

Issues Resolved

#7011

Evidence

Captura de pantalla 2024-09-25 a la(s) 11 29 00 a  m

Test

  • Navigate to endpoint summary
  • Click on an agent
  • Unpinned the agent

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.8% ( 4069 / 29480 )
Branches 9.16% ( 1765 / 19264 )
Functions 13.45% ( 959 / 7127 )
Lines 13.97% ( 3965 / 28366 )

@chantal-kelm chantal-kelm linked an issue Sep 25, 2024 that may be closed by this pull request
Style breaks when unpinned an agent in Safari #7011
Closed
Machi3mfl
Machi3mfl approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screen.Recording.2024-09-26.at.1.37.42.PM.mov

asteriscos
asteriscos approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢

@asteriscos asteriscos merged commit 05c2f46 into 4.9.1 Sep 26, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7011-style-breaks-when-unpinned-an-agent-in-safari branch September 26, 2024 16:41
@asteriscos asteriscos mentioned this pull request Sep 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style breaks when unpinned an agent in Safari
4 participants
@chantal-kelm @Machi3mfl @asteriscos @Desvelao