Fix when generating a PDF report, the open report button in safari does not work #7019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
reviewed
Sep 26, 2024
Comment on lines
97
to
114
| onClick={() => { | ||
| // Open the new tab immediately | ||
| const windowReference = window.open('', '_blank'); | ||
|
|
||
| // Verify if the new tab was locked | ||
| if (windowReference) { | ||
| // Get the URL (in this case, it is obtained directly, but it can be asynchronous) | ||
| const url = getHttp().basePath.prepend( | ||
| `/reports/${filename}`, | ||
| ); | ||
|
|
||
| // Then assign the URL to the new tab | ||
| windowReference.location = url; | ||
| } else { | ||
| // If the tab is locked, it displays an alert to the user. | ||
| alert('The tab was blocked. Please enable pop-up windows.'); | ||
| } | ||
| }} |
There was a problem hiding this comment.
thought: I see you changed to window.open. For this case, we could try a cleaner solution using a link instead of manage the access to the report with a onClick. Could you try it?
In the case we implement the proposed solution in the onClick, there are more usages of window.open that could be failing in Safari too. We should review them.
Desvelao
reviewed
Sep 26, 2024
CHANGELOG.md
Outdated
| @@ -21,6 +21,7 @@ All notable changes to the Wazuh app project will be documented in this file. | |||
| - Fixed missing options depending on agent operating system in the agent configuration report [#6983](https://github.com/wazuh/wazuh-dashboard-plugins/pull/6983) | |||
| - Fixed an style that affected the Discover plugin [#6989](https://github.com/wazuh/wazuh-dashboard-plugins/pull/6989) | |||
| - Fixed a problem updating the API host registry in the GET /api/check-stored-api [#6995](https://github.com/wazuh/wazuh-dashboard-plugins/pull/6995) | |||
| - Fixed, when generating a PDF report, the open report button in safari does not work [#7019](https://github.com/wazuh/wazuh-dashboard-plugins/pull/7019) | |||
There was a problem hiding this comment.
Suggested change
| - Fixed, when generating a PDF report, the open report button in safari does not work [#7019](https://github.com/wazuh/wazuh-dashboard-plugins/pull/7019) | |
| - Fixed the `Open report` button does not work on Safari [#7019](https://github.com/wazuh/wazuh-dashboard-plugins/pull/7019) |
…pen-report-button-in-safari-does-not-work
|
|
|
Machi3mfl
approved these changes
Sep 26, 2024
asteriscos
reviewed
Sep 26, 2024
asteriscos
approved these changes
Sep 26, 2024
asteriscos
deleted the
bug/7018-when-generating-a-PDF-report-the-open-report-button-in-safari-does-not-work
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix when generating a PDF report, the open report button in safari does not work
Issues Resolved
#7018
Evidence
Grabacion.de.pantalla.2024-09-25.a.la.s.4.16.02.p.m.mov
Test
[Provide instructions to test this PR
Go to some module
Click on generate pdf report
Click on open report button
Check List
yarn test:jest