Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter expands outside the viewport and cannot be removed #7021

Merged
merged 6 commits into from
Sep 27, 2024
Merged

Filter expands outside the viewport and cannot be removed #7021

merged 6 commits into from
Sep 27, 2024

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Sep 26, 2024 •
edited by asteriscos
Loading

Description

When filtering by value in the datagrid used in the vulnerability module, the filter goes out of the viewport and cannot be closed.

Issues Resolved

#7017

Evidence

image

Test

  1. Open any application.
  2. Apply any filter.
  3. Edit the filter value to a longer text.
Peek.2024-09-26.16-48.mp4

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Machi3mfl
Machi3mfl previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-26 at 5 00 59 PM

@asteriscos asteriscos linked an issue Sep 27, 2024 that may be closed by this pull request
Filter expands outside the viewport and cannot be removed #7017
Closed
asteriscos
asteriscos approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.8% ( 4069 / 29477 )
Branches 9.16% ( 1765 / 19264 )
Functions 13.46% ( 959 / 7124 )
Lines 13.97% ( 3965 / 28363 )

@asteriscos asteriscos merged commit a2ed51d into 4.9.1 Sep 27, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7017-filter-expands-outside-the-viewport-and-cannot-be-removed branch September 27, 2024 11:22
@asteriscos asteriscos mentioned this pull request Sep 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@Machi3mfl Machi3mfl Awaiting requested review from Machi3mfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter expands outside the viewport and cannot be removed
3 participants
@guidomodarelli @Machi3mfl @asteriscos