Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PDF report footer year #7023

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Remove PDF report footer year #7023

merged 2 commits into from
Sep 27, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Sep 27, 2024 •
edited
Loading

Description

This pull request removes the year from the PDF reports footer.

Issues Resolved

#7013

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos linked an issue Sep 27, 2024 that may be closed by this pull request
Outdated year in PDF report footer copyright #7013
Closed
gdiazlo
gdiazlo approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@gdiazlo gdiazlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asteriscos asteriscos self-assigned this Sep 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.8% ( 4069 / 29477 )
Branches 9.16% ( 1765 / 19264 )
Functions 13.46% ( 959 / 7124 )
Lines 13.97% ( 3965 / 28363 )

@asteriscos asteriscos merged commit de050d9 into 4.9.1 Sep 27, 2024
5 checks passed
@asteriscos asteriscos deleted the change/7013-remove-pdf-report-footer-year branch September 27, 2024 11:35
@asteriscos asteriscos mentioned this pull request Sep 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdiazlo gdiazlo gdiazlo approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated year in PDF report footer copyright
2 participants
@asteriscos @gdiazlo