Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed no agent alert spawn with selected agent in agent welcome #7029

Conversation

JuanGarriuz
Copy link
Member

Description

This PR add a new hoc to controll the render of no-agent-alert when navigate to a agent-welcome page

Issues Resolved

Evidence

Grabacion.2024-09-25.165509.mp4

Test

When navigating to agent-welcome for the first time, the error appears. Try navigating from the endpoints summary, not just by clicking on the agents, but also using the side options to verify that the 'no agents' alert does not render.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Sep 27, 2024
@JuanGarriuz JuanGarriuz linked an issue Sep 27, 2024 that may be closed by this pull request
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.08% ( 4175 / 29634 )
Branches 9.17% ( 1771 / 19292 )
Functions 13.74% ( 985 / 7165 )
Lines 14.28% ( 4073 / 28520 )

@chantal-kelm chantal-kelm self-requested a review September 27, 2024 17:38
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Grabacion.de.pantalla.2024-09-27.a.la.s.2.57.14.p.m.mov

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screen.Recording.2024-09-27.at.5.27.03.PM.mov

@asteriscos asteriscos merged commit 05ebac5 into 4.10.0 Sep 30, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7020-fix-no-agent-alert-spawn-with-selected-agent-in-agent-wellcome branch September 30, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No agent selected prompt on initial load in endpoint summary
4 participants