-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed no agent alert spawn with selected agent in agent welcome #7029
Merged
asteriscos
merged 3 commits into
4.10.0
from
bug/7020-fix-no-agent-alert-spawn-with-selected-agent-in-agent-wellcome
Sep 30, 2024
Merged
Fixed no agent alert spawn with selected agent in agent welcome #7029
asteriscos
merged 3 commits into
4.10.0
from
bug/7020-fix-no-agent-alert-spawn-with-selected-agent-in-agent-wellcome
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected-agent-in-agent-wellcome
|
|
|
chantal-kelm
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✅
TEST: ✅
Grabacion.de.pantalla.2024-09-27.a.la.s.2.57.14.p.m.mov
Machi3mfl
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✅
Test: ✅
Screen.Recording.2024-09-27.at.5.27.03.PM.mov
asteriscos
deleted the
bug/7020-fix-no-agent-alert-spawn-with-selected-agent-in-agent-wellcome
branch
September 30, 2024 10:06
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a new hoc to controll the render of no-agent-alert when navigate to a agent-welcome page
Issues Resolved
Evidence
Grabacion.2024-09-25.165509.mp4
Test
When navigating to agent-welcome for the first time, the error appears. Try navigating from the endpoints summary, not just by clicking on the agents, but also using the side options to verify that the 'no agents' alert does not render.
Check List
yarn test:jest