Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the font size of the kpi subtitles and the features descriptions #7033

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Increase the font size of the kpi subtitles and the features descriptions #7033

merged 7 commits into from
Oct 1, 2024
+61 −54

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Sep 30, 2024 •
edited
Loading

Description

Text sizes: We want to increase the font size of the KPI subtitles and the features descriptions.

Issues Resolved

#7027

Evidence

image
image

Test

Go to Overview page and check the size of the KPI subtitles and the features descriptions

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli self-assigned this Sep 30, 2024
@guidomodarelli guidomodarelli linked an issue Sep 30, 2024 that may be closed by this pull request
Improve the overview page #7027
Closed
6 tasks
@guidomodarelli guidomodarelli mentioned this pull request Sep 30, 2024
Closed
6 tasks
Machi3mfl

This comment was marked as resolved.

Sign in to view

@guidomodarelli guidomodarelli force-pushed the enhancement/7027-increase-the-font-size-of-the-kpi-subtitles-and-the-features-descriptions branch from 4a827e5 to 66c0e49 Compare October 1, 2024 13:36
Tostti
Tostti requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢
image

CR 🟢

Tests 🔴
Please upgrade the snapshots

asteriscos
asteriscos previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Main plugin code coverage (Jest) test % values
Statements 14.09% ( 4177 / 29636 )
Branches 9.17% ( 1771 / 19292 )
Functions 13.74% ( 985 / 7165 )
Lines 14.28% ( 4075 / 28522 )

@guidomodarelli guidomodarelli requested review from Machi3mfl and removed request for Machi3mfl October 1, 2024 14:08
@asteriscos asteriscos dismissed Machi3mfl’s stale review October 1, 2024 14:48

The message is marked as solved.

@asteriscos asteriscos merged commit 0a402f1 into 4.10.0 Oct 1, 2024
5 checks passed
@asteriscos asteriscos deleted the enhancement/7027-increase-the-font-size-of-the-kpi-subtitles-and-the-features-descriptions branch October 1, 2024 14:48
@asteriscos asteriscos mentioned this pull request Oct 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

@asteriscos asteriscos asteriscos approved these changes

@Machi3mfl Machi3mfl Machi3mfl left review comments

Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the overview page
4 participants
@guidomodarelli @Machi3mfl @asteriscos @Tostti