Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update malware feature description #7036

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Update malware feature description #7036

merged 3 commits into from
Oct 1, 2024

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Sep 30, 2024 •
edited
Loading

Description

Malware feature: We want to change its current description by Check indicators of compromise triggered by malware infections or cyberattacks.

Issues Resolved

#7027

Evidence

image

Test

Navigate to the overview page and review the description of Malware Detection.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli self-assigned this Sep 30, 2024
@guidomodarelli guidomodarelli linked an issue Sep 30, 2024 that may be closed by this pull request
Improve the overview page #7027
Closed
6 tasks
@guidomodarelli guidomodarelli mentioned this pull request Sep 30, 2024
Closed
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.08% ( 4175 / 29634 )
Branches 9.17% ( 1771 / 19292 )
Functions 13.74% ( 985 / 7165 )
Lines 14.28% ( 4073 / 28520 )

Machi3mfl
Machi3mfl approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Before

Screenshot 2024-09-30 at 2 12 56 PM

After

Screenshot 2024-09-30 at 2 12 28 PM

@chantal-kelm chantal-kelm self-requested a review September 30, 2024 20:49
chantal-kelm
chantal-kelm approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Captura de pantalla 2024-09-30 a la(s) 5 49 34 p  m Captura de pantalla 2024-09-30 a la(s) 5 49 43 p  m

@asteriscos asteriscos merged commit 663fc9e into 4.10.0 Oct 1, 2024
5 checks passed
@asteriscos asteriscos deleted the enhancement/7027-update-malware-feature-description branch October 1, 2024 11:35
@asteriscos asteriscos mentioned this pull request Oct 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the overview page
4 participants
@guidomodarelli @Machi3mfl @chantal-kelm @asteriscos