Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove virustotal feature and dashboards in favor of malware dashboard #7038

Merged
merged 21 commits into from
Oct 11, 2024
Merged

Remove virustotal feature and dashboards in favor of malware dashboard #7038

merged 21 commits into from
Oct 11, 2024

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Sep 30, 2024 •
edited by Desvelao
Loading

Description

This pull request removes the VirusTotal application in favor to Malware Detection that are included there and move the VirusTotal sample data to Malware Detection category and adds YARA to the description.

Issues Resolved

#7027

Evidence

Before

Screenshot_20240930_110640
image

After

image
image

Test

Navigate to the overview page and ensure that the VirusTotal feature and dashboards do not exist.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli self-assigned this Sep 30, 2024
@guidomodarelli guidomodarelli changed the base branch from master to 4.10.0 September 30, 2024 14:09
@guidomodarelli guidomodarelli force-pushed the change/7027-remove-virustotal-feature-and-dashboards-in-favor-of-malware-dashboard branch from 17248d1 to 076d338 Compare September 30, 2024 15:03
@guidomodarelli guidomodarelli linked an issue Sep 30, 2024 that may be closed by this pull request
Improve the overview page #7027
Closed
6 tasks
@guidomodarelli guidomodarelli mentioned this pull request Sep 30, 2024
Closed
6 tasks
Machi3mfl
Machi3mfl previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Before

Screenshot 2024-09-30 at 2 15 58 PM

After

Screenshot 2024-09-30 at 2 15 43 PM

JuanGarriuz
JuanGarriuz previously approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@JuanGarriuz JuanGarriuz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢

image

@JuanGarriuz JuanGarriuz self-requested a review October 2, 2024 06:57
@JuanGarriuz JuanGarriuz self-requested a review October 2, 2024 07:00
@guidomodarelli guidomodarelli dismissed stale reviews from JuanGarriuz and Machi3mfl via dfce1d5 October 2, 2024 16:35
JuanGarriuz
JuanGarriuz previously approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

JuanGarriuz
JuanGarriuz previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Desvelao
Desvelao reviewed Oct 8, 2024
View reviewed changes
Desvelao
Desvelao reviewed Oct 8, 2024
View reviewed changes
@guidomodarelli @Desvelao
Update CHANGELOG.md
2206464 
Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
Desvelao
Desvelao approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.1% ( 4172 / 29576 )
Branches 9.23% ( 1779 / 19261 )
Functions 13.79% ( 985 / 7141 )
Lines 14.29% ( 4070 / 28462 )

@Desvelao Desvelao merged commit 2c08f43 into 4.10.0 Oct 11, 2024
5 checks passed
@Desvelao Desvelao deleted the change/7027-remove-virustotal-feature-and-dashboards-in-favor-of-malware-dashboard branch October 11, 2024 13:45
@asteriscos asteriscos mentioned this pull request Oct 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@Machi3mfl Machi3mfl Machi3mfl left review comments

@JuanGarriuz JuanGarriuz JuanGarriuz left review comments

Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the overview page
5 participants
@guidomodarelli @Machi3mfl @Desvelao @JuanGarriuz @asteriscos