Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the filter are displayed cropped on screens of 575px to 767px #7047

Conversation

chantal-kelm
Copy link
Member

Description

Fix the filter are displayed cropped on screens of 575px to 767px

Issues Resolved

#7040

Evidence

Captura de pantalla 2024-10-01 a la(s) 3 27 07 p  m Captura de pantalla 2024-10-01 a la(s) 3 14 13 p  m Captura de pantalla 2024-10-01 a la(s) 3 14 00 p  m

Test

  • Go to the vulnerability detection module

  • Add a long filter

  • Check that the filter is not cut off on screens of 575px to 767px

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Oct 1, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could start using something like this: https://stackoverflow.com/a/49421832/12151113

@JuanGarriuz JuanGarriuz linked an issue Oct 2, 2024 that may be closed by this pull request
@JuanGarriuz JuanGarriuz self-requested a review October 2, 2024 07:03
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image

LGTM!!

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: 🟢
CR: 🟢

image

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Main plugin code coverage (Jest) test % values
Statements 14.09% ( 4177 / 29637 )
Branches 9.22% ( 1779 / 19293 )
Functions 13.74% ( 985 / 7166 )
Lines 14.28% ( 4075 / 28523 )

@asteriscos asteriscos merged commit 4431ff6 into 4.10.0 Oct 2, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7040-fix-the-filter-are-displayed-cropped-on-screens-of-575px-to-767px branch October 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The filter is shown cut off on screens of 767px or less
4 participants