-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pinned agent mechanic to inventory data, stats, and configuration for consistent functionality #7135
Added pinned agent mechanic to inventory data, stats, and configuration for consistent functionality #7135
Conversation
… enhanced agent interaction and updated layout consistency
…ency in functionality and user experience
…e-pinned-agent-mechanic
…t and improved background styling
…s and hover states for better maintainability
…es for better flexibility and maintainability
…ribute and simplifying JSX for cleaner code readability
…abs for improved coverage and verification of UI functionality
…e-pinned-agent-mechanic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: 🟢
Test: 🟢
Peek.2024-10-29.18-19.mp4
…abs for improved coverage and verification of UI functionality refactor: enhance MainModuleAgent layout by adding margin and padding styles to EuiFlexItems for improved UI consistency
…nd code consistency in explore agent button component
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…, stats, and configuration for consistency across pages
…nt for safer access to sorting fields when rendering table
…able rendering for different agent IDs in syscollector component
…ltiple syscollector table components during rendering
…s and rendering behavior for changing agent IDs
…le for clarity on data being fetched for given agent IDs
…and rendering behavior for different agent IDs
…ontext in related API request tests
…API requests for changing agent IDs
…ests when switching between agent IDs
@guidomodarelli Do you remove the endpoints summary redirect when unpinning an agent? Screen.Recording.2024-11-01.at.5.58.16.PM.mov |
Yes, It's okay. It's to prevent flickering. |
Test UpdatedGrabacion.2024-10-29.094722.mp4 |
…ields in network tables for better readability
…and endpoint rendering in various system collector tables
plugins/main/public/components/common/hooks/useGenericRequest.ts
Outdated
Show resolved
Hide resolved
b6507df
to
924e8e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grabacion.de.pantalla.2024-11-04.a.la.s.5.13.44.p.m.mov
Grabacion.de.pantalla.2024-11-04.a.la.s.5.12.59.p.m.mov
…e-pinned-agent-mechanic
… related logic for clarity
|
|
|
Description
Inventory data, stats, and configuration must include the pinned agent mechanic.
Issues Resolved
Closes #7130
Evidence
Verify the presence of the "Pinned Agent" button
Changing the pinned agent in "Configuration" should alter the data.
Peek.2024-10-30.12-56.mp4
Changing the pinned agent in "Stats" should alter the data.
Peek.2024-10-30.15-49.mp4
Changing the pinned agent in "Inventory Data" should alter the data.
Software tab
Peek.2024-10-30.15-21.mp4
Network tab
Peek.2024-10-30.15-24.mp4
Processes tab
Peek.2024-10-30.15-26.mp4
Changing the pinned agent in "Inventory Data" should initiate a new request regarding the ribbon.
Peek.2024-10-30.14-50.mp4
[Update 2024/11/01] Upon unpinning the agent, you should be redirected to the
PromptNoSelectedAgent
page, and the breadcrumb to be updated accordingly.Peek.2024-11-01.12-28.mp4
Tests
Verify the presence of the "Pinned Agent" button
🟢 Unit tests
Clicking on unPinAgent should redirect you to the
PromptNoSelectedAgent
page, and the breadcrumb will be updated accordingly.PromptNoSelectedAgent
page.Endpoints
).Endpoints
»{agent}
).PromptNoSelectedAgent
page.Endpoints
»{agent}
»Inventory Data
).PromptNoSelectedAgent
page.Endpoints
»{agent}
»Inventory Data
).PromptNoSelectedAgent
page.Endpoints
»{agent}
»Inventory Data
).PromptNoSelectedAgent
page.Endpoints
»{agent}
»Stats
).PromptNoSelectedAgent
page.Endpoints
»{agent}
»Configuration
).Changing the pinned agent in "Configuration" should alter the data.
Changing the pinned agent in "Stats" should alter the data.
🟢 Unit tests
Changing the pinned agent in "Inventory Data" should alter the data.
Warning
A new table appears with the Windows agent.
🟢 Unit tests
Changing the pinned agent in "Inventory Data" should initiate a new request regarding the ribbon.
🟢 Unit tests
Ensure that the line on the top bar is displayed across the entire bar, not just over the tabs.
BEFORE
AFTER
Check List
yarn test:jest