Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fim data values to a common file #7163

Merged
merged 9 commits into from
Nov 21, 2024
Merged

Move fim data values to a common file #7163

merged 9 commits into from
Nov 21, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Nov 15, 2024 •
edited
Loading

Description

Solve inode not be rendered in FIM inventory view and move some constants to a common file.

Issues Resolved

Evidence

4.10.0

Linux

image
image

Windows

The global changes have affected the order. If a specific order is required, it can be fixed before merging the PR.

image
image
image
image

This PR

Linux

image
image

Windows

image
image
image
image

Test

[Provide instructions to test this PR]

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Nov 15, 2024
@JuanGarriuz JuanGarriuz linked an issue Nov 15, 2024 that may be closed by this pull request
FIM flyout filters not working #7082
Closed
@JuanGarriuz JuanGarriuz marked this pull request as ready for review November 18, 2024 11:45
Desvelao
Desvelao reviewed Nov 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Desvelao
Desvelao reviewed Nov 18, 2024
View reviewed changes
plugins/main/public/components/agents/fim/inventory/fim-data.tsx
);
}

const dataFIM = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: add an explanation about the data structure and the meaning of the fields. This could be useful in the future.

asteriscos
asteriscos previously approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Peek.2024-11-18.17-17.mp4

asteriscos
asteriscos previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢

Peek 2024-11-19 14-05

asteriscos
asteriscos previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Peek 2024-11-20 11-20

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.9% ( 4436 / 29767 )
Branches 9.8% ( 1886 / 19235 )
Functions 14.66% ( 1056 / 7199 )
Lines 15.11% ( 4330 / 28639 )

asteriscos
asteriscos approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

image

image

image

@asteriscos asteriscos merged commit 21b812d into 4.10.0 Nov 21, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7082-fim-inode-not-reder branch November 21, 2024 15:38
@asteriscos asteriscos mentioned this pull request Nov 25, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@asteriscos asteriscos asteriscos approved these changes

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIM flyout filters not working
3 participants
@JuanGarriuz @asteriscos @Desvelao