Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data.vulnerability.reference field formatting fix on tables and flyouts #7177

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Data.vulnerability.reference field formatting fix on tables and flyouts #7177

merged 3 commits into from
Nov 27, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Nov 26, 2024 •
edited
Loading

Description

Fixed the rendering of the data.vunerability.reference in the table and flyout

Issues Resolved

Evidence

Vulnerability > Inventory

image
image

Vulnerability > Events

image
image

Test

  1. Add sample data
  2. Check that the field data.vulnerability.reference exists
  3. Navigate to Vulnerability detection > Events
  4. Check that the data.vulnerability.reference column shows external links.
  5. Check that the data.vulnerability.reference field of the flyout shows external links.
  6. Test the same in Vulnerability detection > Inventory

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Nov 26, 2024
@yenienserrano yenienserrano linked an issue Nov 26, 2024 that may be closed by this pull request
References to the vulnerability links are not rendered correctly. #7176
Closed
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@yenienserrano yenienserrano changed the title Fix/7176 references to the vulnerability links are not rendered correctly Data.vulnerability.reference field formatting fix on tables and flyouts Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.92% ( 4445 / 29774 )
Branches 9.77% ( 1877 / 19206 )
Functions 14.68% ( 1057 / 7200 )
Lines 15.14% ( 4339 / 28646 )

guidomodarelli
guidomodarelli reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫ 🠊 The test hasn't started yet.
🟢 🠊 All checks passed.
🟡 🠊 There is at least one expected fail or skipped test and no failures.
🔴 🠊 There is at least one failed check.
⚪ 🠊 Doesn't apply.
🔧 🠊 Request changes.

CR 🟢
TEST 🟢

Check that the field data.vulnerability.reference exists.
image

Navigate to Vulnerability detection > Events.
Check that the data.vulnerability.reference column shows external links.
image

image

Check that the data.vulnerability.reference field of the flyout shows external links.
image

Test the same in Vulnerability detection > Inventory
image

image

guidomodarelli
guidomodarelli approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chantal-kelm chantal-kelm self-requested a review November 26, 2024 18:46
chantal-kelm
chantal-kelm approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Captura de pantalla 2024-11-26 a la(s) 3 59 10 p  m Captura de pantalla 2024-11-26 a la(s) 3 58 34 p  m Captura de pantalla 2024-11-26 a la(s) 3 54 53 p  m Captura de pantalla 2024-11-26 a la(s) 3 54 16 p  m

asteriscos
asteriscos approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

Events
image

image

Inventory
image

image

@asteriscos asteriscos merged commit 871de7e into 4.10.0 Nov 27, 2024
5 checks passed
@asteriscos asteriscos deleted the fix/7176-references-to-the-vulnerability-links-are-not-rendered-correctly branch November 27, 2024 09:37
@Tostti Tostti mentioned this pull request Dec 9, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@guidomodarelli guidomodarelli guidomodarelli approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

References to the vulnerability links are not rendered correctly.
4 participants
@yenienserrano @asteriscos @guidomodarelli @chantal-kelm