-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added limit to FIM csv export #7182
Added limit to FIM csv export #7182
Conversation
6379576
…-many-files-on-fim
…-many-files-on-fim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legend:
⚫ 🠆 The test hasn't started yet.
🟢 🠆 All checks passed.
🟡 🠆 There is at least one expected fail or skipped test and no failures.
🔴 🠆 There is at least one failed check.
⚪ 🠆 Doesn't apply.
🔧 🠆 Request changes.
CR 🔧
TEST 🟢
-
Verify that there are more than 10.000 files and the warning message appears. 🟢
-
Click on
Export formatted
and verify that the exported file only contains 10.000 results. 🟢 -
Change the sorting in the table, click on
Export formatted
and verify that the exported file is sorted like the table. 🟢 -
Apply some search term to reduce the number of files to less than 10.000 and verify that the warning is not shown. 🟢
-
Click on
Export formatted
and verify that the exported report contains the same results shown in the table. 🟢 -
Navigate to
Dashboard management
>App Settings
and change thereports.csv.maxRows
setting to a different number. -
Verify that there are more than 1.000 files and the warning message appears. 🟢
-
Click on
Export formatted
and verify that the exported file only contains 1.000 results. 🟢 -
Change the sorting in the table, click on
Export formatted
and verify that the exported file is sorted like the table. 🟢 -
Apply some search term to reduce the number of files to less than 1.000 and verify that the warning is not shown. 🟢
-
Click on
Export formatted
and verify that the exported report contains the same results shown in the table. 🟢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legend:
⚫ 🠆 The test hasn't started yet.
🟢 🠆 All checks passed.
🟡 🠆 There is at least one expected fail or skipped test and no failures.
🔴 🠆 There is at least one failed check.
⚪ 🠆 Doesn't apply.
🔧 🠆 Request changes.
CR 🟢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legend:
⚫ 🠆 The test hasn't started yet.
🟢 🠆 All checks passed.
🟡 🠆 There is at least one expected fail or skipped test and no failures.
🔴 🠆 There is at least one failed check.
⚪ 🠆 Doesn't apply.
🔧 🠆 Request changes.
CR 🟢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test 🟢Verify that there are more than 10.000 files and the warning message appears. Click on Export formatted and verify that the exported file only contains 10.000 results. Change the sorting in the table, click on Export formatted and verify that the exported file is sorted like the table. Apply some search term to reduce the number of files to less than 10.000 and verify that the warning is not shown. Click on Export formatted and verify that the exported report contains the same results shown in the table. Navigate to Dashboard management > App Settings and change the reports.csv.maxRows setting to a different number CR 🟢 |
|
|
|
Description
This PR adds:
Issues Resolved
Evidence
Setting the limit to 1439
Test
Pre requisites
/etc
. You can create the following file inside/etc
bash <filename>
. After that, restart the agent and wait for all the files to be read (it can take some time).File Integrity Monitoring
/Inventory
and select the agent.Test
Verify that there are more than 10.000 files and the warning message appears.
Click on
Export formatted
and verify that the exported file only contains 10.000 results.Change the sorting in the table, click on
Export formatted
and verify that the exported file is sorted like the table.Apply some search term to reduce the number of files to less than 10.000 and verify that the warning is not shown.
Click on
Export formatted
and verify that the exported report contains the same results shown in the table.Navigate to
Dashboard management > App Settings
and change thereports.csv.maxRows
setting to a different numberRepeat the previous steps considering the new set value
Check List
yarn test:jest