Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to construction of arm packages #500

Merged
merged 8 commits into from
Jan 28, 2025
Merged

Fix to construction of arm packages #500

merged 8 commits into from
Jan 28, 2025

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jan 23, 2025 •
edited
Loading

Description

Fixes error when building armed packages due to an attempt to delete an image in use

Issues Resolved

#472

Screenshot

Ubuntu server arm

image

Test

ARM deb

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Jan 23, 2025
@yenienserrano yenienserrano linked an issue Jan 23, 2025 that may be closed by this pull request
[BUG] Package generation GHA workflow fails for ARM architecture #472
Closed
@yenienserrano
Revert "Commit for test"
5d72eba 
This reverts commit ab73b3d.
@JuanGarriuz JuanGarriuz self-requested a review January 24, 2025 08:39
@JuanGarriuz
Copy link
Member

Test wiht UBUNTU AMD-DEB

image

@JuanGarriuz
Copy link
Member

Test-Ubuntu AMD-DEB

image

JuanGarriuz
JuanGarriuz approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

asteriscos
asteriscos approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RPM x86_64 🟢

image

DEB AMD 🟢

image

@asteriscos asteriscos merged commit 910f0b3 into 4.12.0 Jan 28, 2025
60 checks passed
@asteriscos asteriscos deleted the bug/472-bug-package-generation-gha-workflow-fails-for-arm branch January 28, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Package generation GHA workflow fails for ARM architecture
3 participants
@yenienserrano @JuanGarriuz @asteriscos