-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to wazuh.yml file and adapt to the new configuration system #7050
Closed
Desvelao
wants to merge
22
commits into
4.9.0
from
feat/wdp-6201-remove-configuration-file-adapt-new-configuration
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
d5c8c97
feat(dashboard-configuration): adapt the user manual configuration se…
Desvelao 54141af
fix: grammar
Desvelao a98b178
feat: remove reference to wazuh.yml
Desvelao f7a417a
feat: replace the references to configure server API hosts or plugins…
Desvelao 9f1aa5c
fix(wazuh-dashboard): wrong button label
Desvelao 5ff36e0
feat(wazuh-dashboard): add documentation to setup the configuration u…
Desvelao 12bc130
fix(wazuh-dashboard): replace reference to button
Desvelao c376d63
feat(wazuh-dashboard): enhance the configuration section
Desvelao d0c665d
feat(wazuh-configuration): enhance documenation about shareing config…
Desvelao 6c6a752
fix(wazuh-dashboard): fix url to import configuration file
Desvelao a135015
fix(wazuh-dashboard): fix method to import configuration file
Desvelao 5486111
fix(wazuh-dashboard): command to import configuration from file
Desvelao 66a0a03
Add changes from review
javimed cc7ec0b
Apply suggestions from code review
Desvelao 7211ef3
fix: apply suggestions of code review
Desvelao 8ba133b
remove: references to wazuh.yml
Desvelao e1b2eff
fix(wazuh-dashboard): rename reference to configuration file
Desvelao bb5482f
remove(wazuh-dashboard): remove troubleshooting entry because it does…
Desvelao 48eca6a
feat(wazuh-dashboard): add screenshot to check the API connection run_as
Desvelao 0ff1767
feat(wazuh-dashboard): add image to the referentces to check the valu…
Desvelao d96b819
fix(wazuh-dashboard): undone change related to API connection Run as …
Desvelao 9d465bc
feat(wazuh-dashboard): add screenshots related to editing or adding a…
Desvelao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+81.3 KB
...e/images/wazuh-dashboard/api-connections/wazuh-dashboard-add-api-connection.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+93.8 KB
...oard/api-connections/wazuh-dashboard-check-api-connection-run-as-is-enabled.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+93.2 KB
...wazuh-dashboard/api-connections/wazuh-dashboard-check-api-connection-run-as.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+94.2 KB
.../images/wazuh-dashboard/api-connections/wazuh-dashboard-edit-api-connection.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure which image is more appropriate to show here, if the
Run as
is disabled or enabled. What do you think about this @javimed ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I overlooked this question, @Desvelao . We could put the
Run as
is disabled just like the code block we currently have showingfalse
. The image would go after the "If Run as is set to false..." text but before the "If Run as is set to true..." text just like the current code block we have. I think run as false is the simplest configuration option and worth displaying.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The displayed value as
Run as
in the API connections table is not the same value (false
/true
) that is configured in the API hosts. The raw value of theRun as
setting is not displayed. Instead, the displayed value can display a missconfiguration.CC: @asteriscos