-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pagination to SCA table #4653
Conversation
Researching the current issueResearching the behavior of the
|
Tasks in progress
Current endpoints workflow
|
…zuh/wazuh-kibana-app into enhance/4314-SCA-table-paging
…zuh/wazuh-kibana-app into enhance/4314-SCA-table-paging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing this feature, we can identify that the search bar has some problems.
Here I applied a tittle filter and it's ignored by the filter bar.
@Machi3mfl There is a possibility to check this ?
After reviewing the functionallity with @Machi3mfl we found that the environment API was outdated, after download the changes we could check that the filter bar it's working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TR: ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test: ✔️
CR: ✔️
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-4653-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ec037c685d5d5747920dd36c2d0d8052ea294d0
# Push it to GitHub
git push --set-upstream origin backport-4653-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16 Then, create a pull request where the |
* pagination SCA table * Resolved beautifyDate is not a function * Used sca checks with distinct and value in search bar * pagination SCA table * Resolved beautifyDate is not a function * Used sca checks with distinct and value in search bar * Refactored sca inventory sca and added some types * Solved some eslint warnings * Solved review comments Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ec037c)
Fixed pagination to SCA table (#4653) * pagination SCA table * Resolved beautifyDate is not a function * Used sca checks with distinct and value in search bar * pagination SCA table * Resolved beautifyDate is not a function * Used sca checks with distinct and value in search bar * Refactored sca inventory sca and added some types * Solved some eslint warnings * Solved review comments Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ec037c) Co-authored-by: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com>
|
* pagination SCA table * Resolved beautifyDate is not a function * Used sca checks with distinct and value in search bar * pagination SCA table * Resolved beautifyDate is not a function * Used sca checks with distinct and value in search bar * Refactored sca inventory sca and added some types * Solved some eslint warnings * Solved review comments Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ec037c)
Fixed pagination to SCA table (#4653) * pagination SCA table * Resolved beautifyDate is not a function * Used sca checks with distinct and value in search bar * pagination SCA table * Resolved beautifyDate is not a function * Used sca checks with distinct and value in search bar * Refactored sca inventory sca and added some types * Solved some eslint warnings * Solved review comments Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ec037c) Co-authored-by: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com>
…ed beautifyDate is not a function * Used sca checks with distinct and value in search bar * pagination SCA table * Resolved beautifyDate is not a function * Used sca checks with distinct and value in search bar * Refactored sca inventory sca and added some types * Solved some eslint warnings * Solved review comments Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ec037c) # Conflicts: # CHANGELOG.md # public/components/agents/vuls/inventory.tsx # # It looks like you may be committing a cherry-pick. # If this is not correct, please run # git update-ref -d CHERRY_PICK_HEAD # and try again. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Author: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com> # Date: Wed Oct 19 12:04:00 2022 -0300 # # On branch 4.4-7.16 # Your branch is up to date with 'origin/4.4-7.16'. # # You are currently cherry-picking commit 8ec037c. # # Changes to be committed: # modified: CHANGELOG.md # modified: public/components/agents/sca/inventory.tsx # new file: public/components/agents/sca/inventory/checks-table.tsx # new file: public/components/agents/sca/inventory/index.ts # new file: public/components/agents/sca/inventory/lib/api-request.ts # new file: public/components/agents/sca/inventory/lib/index.ts # modified: public/components/agents/vuls/inventory.tsx # modified: public/components/common/tables/table-default.tsx # modified: public/components/common/tables/table-wz-api.tsx # modified: public/components/wz-search-bar/lib/base-handler.ts #
Description
This pull request adds pagination to the table used in the SCA section. This refactor required new endpoints, or new endpoints options (distinct and select) from the Wazuh API.
Issues Resolved