Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when clicking on the multiple agent selector #5094

Merged
merged 4 commits into from
Jan 10, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jan 10, 2023

Description

This pull request fixes a console error displayed when clicking in the multiple agent selector to manage the agents in a group

Issues Resolved

Closes #5091

Evidence

[Provide screenshots or videos to prove this PR solves the issues]

Test

Scenario 1 Clicking on the multiple selector (Available agents) of the group agents management doesn't display any error in the console of the browser dev tools
Given a group without agents
When the user goes to Manage agents
And clicking on selector of the Available agentsCurrent agents in the group panel
Then it should not appear an error in the console of the browser dev tools

Scenario 2 Clicking on the multiple selector (Current agents in the group) of the group agents management doesn't display any error in the console of the browser dev tools
Given a group without agents
When the user goes to Manage agents
And clicking on selector of the Current agents in the group panel
Then it should not appear an error in the console of the browser dev tools

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao requested a review from a team as a code owner January 10, 2023 09:57
@Desvelao Desvelao self-assigned this Jan 10, 2023
@Desvelao Desvelao linked an issue Jan 10, 2023 that may be closed by this pull request
asteriscos
asteriscos previously approved these changes Jan 10, 2023
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✔️
Test: ✔️

image

Tostti
Tostti previously approved these changes Jan 10, 2023
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST: ✔️
CR:✔️

image

LGTM

@asteriscos asteriscos dismissed stale reviews from Tostti and themself via 97fa2a6 January 10, 2023 12:36
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.74% ( 3231 / 36953 )
Branches 4.55% ( 1306 / 28681 )
Functions 7.62% ( 698 / 9160 )
Lines 8.8% ( 3116 / 35384 )

@asteriscos asteriscos merged commit c107045 into 4.4-2.4-wzd Jan 10, 2023
@asteriscos asteriscos deleted the fix/5091-error-click-multiple-agent-selector branch January 10, 2023 12:42
@github-actions
Copy link
Contributor

The backport to 4.4-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5094-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c10704529b4351e3d8b2fe7fed0c8b35734e53d9
# Push it to GitHub
git push --set-upstream origin backport-5094-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16

Then, create a pull request where the base branch is 4.4-7.16 and the compare/head branch is backport-5094-to-4.4-7.16.

@github-actions
Copy link
Contributor

The backport to 4.4-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5094-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c10704529b4351e3d8b2fe7fed0c8b35734e53d9
# Push it to GitHub
git push --set-upstream origin backport-5094-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10

Then, create a pull request where the base branch is 4.4-7.10 and the compare/head branch is backport-5094-to-4.4-7.10.

yenienserrano pushed a commit that referenced this pull request Jan 10, 2023
* fix(): fix console error when clicking in multiple agents selector

* changelog: add entry

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
(cherry picked from commit c107045)
Desvelao added a commit that referenced this pull request Jan 10, 2023
* fix(): fix console error when clicking in multiple agents selector

* changelog: add entry

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
(cherry picked from commit c107045)
yenienserrano pushed a commit that referenced this pull request Jan 10, 2023
…ector (#5096)

Fix error when clicking on the multiple agent selector (#5094)

* fix(): fix console error when clicking in multiple agents selector

* changelog: add entry

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
(cherry picked from commit c107045)
Desvelao added a commit that referenced this pull request Jan 10, 2023
…gent selector (#5095)

Fix error when clicking on the multiple agent selector (#5094)

* fix(): fix console error when clicking in multiple agents selector

* changelog: add entry

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
(cherry picked from commit c107045)

Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error adding a single agent into a group
3 participants