-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix password input in deploy new agent section #5098
Fix password input in deploy new agent section #5098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I think the problem is related to the command used to deploy and Solaris agent doesn't use the password deployment variable and there is an error when trying to match the expected string in the command. I think the problem could be happening for:
If this is the case, we must fix the function that obfuscates the password. I will check it. |
…ttps://github.com/wazuh/wazuh-kibana-app into 5093-fix-password-input-in-deploy-new-agent-section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ttps://github.com/wazuh/wazuh-kibana-app into 5093-fix-password-input-in-deploy-new-agent-section
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review:
Kibana 7.10
Legend:
⚫: none
🟢: passed
🔴: failed
🟡: warning
⚪: not applicable
Test | Chrome | Package |
---|---|---|
Check that the 'Wazuh password' input does not appear in the deploy new agent section. | 🟢 | Kibana 7.10 |
Control that depending on whether the switch is activated or not the hidden password is shown with **** or the previously defined password is shown. | 🟢 | Kibana 7.10 |
Try to choose HP, Solaris or Alpine, check that the variable WAZUH_REGISTRATION_PASSWORD='hello' does not appear in the install command and that the 'show password' switch does not appear either. | 🟢 | Kibana 7.10 |
Check that the 'Wazuh password' entry appears in the deploy new agent section and that you can enter a password without having selected an os yet. | 🟢 | Kibana 7.10 |
Check that depending on whether the switch is activated or not the hidden password is shown with **** or the password you typed in is shown | 🟢 | Kibana 7.10 |
Choose some operating system other than hp, alpine or solaris put a password, check that the hide password switch works fine | 🟢 | Kibana 7.10 |
Choose some operating system other than HP, Alpine or Solaris set a password, check that the password hiding switch works fine, now choose HP, Solaris or Alpine check that the ui is not broken. | 🟢 | Kibana 7.10 |
Try choosing hp, solaris or alpine, the password input and the switch should not appear. | 🟢 | Kibana 7.10 |
Details
🟢 Control that depending on whether the switch is activated or not the hidden password is shown with **** or the previously defined password is shown.
Chrome - 🟢
🟢 Try to choose HP, Solaris or Alpine, check that the variable WAZUH_REGISTRATION_PASSWORD='hello' does not appear in the install command and that the 'show password' switch does not appear either.
Chrome - 🟢
🟢 Check that the 'Wazuh password' entry appears in the deploy new agent section and that you can enter a password without having selected an os yet.
Chrome - 🟢
🟢 Check that depending on whether the switch is activated or not the hidden password is shown with **** or the password you typed in is shown
Chrome - 🟢
🟢 Choose some operating system other than hp, alpine or solaris put a password, check that the hide password switch works fine
Chrome - 🟢
🟢 Choose some operating system other than HP, Alpine or Solaris set a password, check that the password hiding switch works fine, now choose HP, Solaris or Alpine check that the ui is not broken.
Chrome - 🟢
* register agent section: password * changelog * fixed solaris, hp and alpine password input and added some styles * fixed the textToCopy error displayed in the console (cherry picked from commit b3b0222)
* register agent section: password * changelog * fixed solaris, hp and alpine password input and added some styles * fixed the textToCopy error displayed in the console (cherry picked from commit b3b0222)
…#5111) Fix password input in deploy new agent section (#5098) * register agent section: password * changelog * fixed solaris, hp and alpine password input and added some styles * fixed the textToCopy error displayed in the console (cherry picked from commit b3b0222) Co-authored-by: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com>
…5110) Fix password input in deploy new agent section (#5098) * register agent section: password * changelog * fixed solaris, hp and alpine password input and added some styles * fixed the textToCopy error displayed in the console (cherry picked from commit b3b0222) Co-authored-by: Chantal Belén kelm <99441266+chantal-kelm@users.noreply.github.com>
Description
The following use cases have been fixed:
When a user enables authentication and sets a default password
When a user enables authentication and enters a password at login
Issues Resolved
#5093
Evidence
When a user enables authentication and sets a default password:
When a user enables authentication and enters a password at login:
Fixed the 'textToCopy' error displayed in the console:
Test
For the first case:
add these lines to the imposter's wazuh-config.yml file:
Create a ossec folder with a ossec.json file where you are going to put these lines of code:
For the second case:
"authd.pass": "hola",
*Go to the deploy new agent section.
First case:
Second case:
Check List
yarn test:jest