About testing #1778
-
|
Dear community members, Recently, I opened several PRs based on my previous experiences with troubleshooting the issues I faced during installation. Funnily, I was expecting a complicated issue and spent a week in depths. It turned out to be just a firewall issue. I expected something more complex like the glibc issue I have encountered. I searched for a CONTRIBUTING.md for bash scripting guidelines, naming conventions, testing standards, etc. Yet, I could not succeed. So, I could not write tests for my current PRs. Well, I hesitated to do something half baked, actually. However, I assume you already have some docs internally. So you intend to share a set of guidelins in Github? Also, before that, can you help me with writing tests for the PRs? Best regards, Zafer |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment
-
|
Hello @zbalkan Your contributions are really appreciated. Indeed, we need to publish a CONTRIBUTING guide as soon as possible, it's in our roadmap. Thanks again and sorry for the inconvenience. Edit: we did something that contains some guidelines: https://github.com/wazuh/wazuh-packages/blob/4.3/unattended_installer/Development-guide.md |
Beta Was this translation helpful? Give feedback.
Hello @zbalkan
Your contributions are really appreciated. Indeed, we need to publish a CONTRIBUTING guide as soon as possible, it's in our roadmap.
Meanwhile, we usually follow Shellcheck recommendations for
bash. Regarding the tests, we have an unmaintained unit-testing part but you can add totestfolder whatever test you consider. We will normalize this as soon as we can this part too.Thanks again and sorry for the inconvenience.
Edit: we did something that contains some guidelines: https://github.com/wazuh/wazuh-packages/blob/4.3/unattended_installer/Development-guide.md