Added configurable MSI download location for offline environments #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Fabian1976, The changes look good, we will run some tests on them and let you know the results as soon as possible. Thanks for contributing, it's really appreciated! Greetings, |
|
Hello again @Fabian1976, I just tested the changes manually and through our Github Actions tests https://github.com/wazuh/wazuh-puppet/runs/118685460. LGTM ! Greetings, JP |
manuasir
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make the download location of the MSI package configurable.
Because we work mainly in Enterprise environments and they tend to have no Internet access on their servers, i would like this merged so that in future version, we can configure our own download location.
It would be even better if their would be (configurable) support for chocolatey. But I believe this is allready a step in the right direction.