Repo management in dashboard class #529
Conversation
|
LGTM |
poloz-lab
force-pushed
the
feature-528-repo-management-dashboard
branch
from
531dd1a
to
6974b97
Compare
There was a problem hiding this comment.
Hello @poloz-lab
Thanks for your patience and contribution. We are working hard to review all the requests as soon as possible. Currently, we are reviewing this PR.
The development of this PR is greatly appreciated, we will be merging it and it will be available in the next Wazuh release.
Thank you very much and if you have any questions or ideas, do not hesitate to contact us.
|
Hi @vcerenu , Thanks for your approval and for your time reviewing. Have a nice day ! |
files_lines resources need the configuration file from the package.
poloz-lab
force-pushed
the
feature-528-repo-management-dashboard
branch
from
6974b97
to
c1f059e
Compare
|
Hi @vcerenu , Sorry for this late fix. I changed the require for an include as you can see in the compare. I did this to avoid a dependency to the wazuh::repo class for the whole wazuh::dashboard class. The sufficient dependency is declared on line 34 or 36. This doesn't change the behaviour under normal operation. |
|
LGTM |
When the Wazuh dashboard is not installed on the same machine as the Wazuh manager or indexer, the Wazuh repository is not configured.
This PR adds a parameter in Wazuh dashboard class to manage the repos as in the Wazuh indexer class.
This PR also fixes the dependencies between the resources in the Wazuh dashboard class to make it possible.
Resolves #528
Tested on a Debian 10 machine.