Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix username (puppet to puppetlabs) #74

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Fix username (puppet to puppetlabs) #74

merged 1 commit into from
Nov 30, 2018

Conversation

hfm
Copy link
Contributor

@hfm hfm commented Sep 19, 2018

puppet/firewall doesn't exist. It seems to be https://forge.puppet.com/puppetlabs/firewall.

@jesuslinares jesuslinares added this to the Weekly sprint - 47th milestone Nov 19, 2018
@jesuslinares jesuslinares self-requested a review November 19, 2018 09:52
@SitoRBJ SitoRBJ self-requested a review November 30, 2018 17:05
SitoRBJ
SitoRBJ approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@SitoRBJ SitoRBJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hfm,

This PR solves the problem correctly, we proceed to merge the code.

Thank you for your contribution.

Kind regards,

Alfonso Ruiz-Bravo

@SitoRBJ SitoRBJ merged commit b75a182 into wazuh:master Nov 30, 2018
@hfm hfm deleted the patch-1 branch November 30, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SitoRBJ SitoRBJ SitoRBJ approved these changes

@jesuslinares jesuslinares Awaiting requested review from jesuslinares

Assignees

@cadoming cadoming

Labels
None yet
Projects
None yet
Milestone
Weekly sprint - 48th
Development

Successfully merging this pull request may close these issues.
4 participants
@hfm @SitoRBJ @jesuslinares @cadoming