Change ami and ova workflows input upper_case to lower_case #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enaraque
changed the title
CarlosALgit
previously approved these changes
Nov 7, 2024
CarlosALgit
approved these changes
Nov 8, 2024
teddytpc1
approved these changes
Nov 8, 2024
teddytpc1
deleted the
bug/113-request-for-changes-to-standardize-parameters-in-workflows-for-ova-and-ami-creation-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, in the
workflow_dispatchof the OVA and AMI build workflows, inputs in upper_case were used. In order to follow a standard in the format of the inputs with the rest of the workflows, the style has been changed to lower_case.Testing
Tests have been performed on both workflows to verify that everything is still working as expected. In the AMI workflow it has been completely executed and in the OVA workflow it has been stopped from the steps that did not use the inputs.
Both workflows have been executed correctly.
Related issue