Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zstd support on legacy record and ensure no variable is referred before definition #138

Merged
merged 7 commits into from
Mar 26, 2024
Merged

Add zstd support on legacy record and ensure no variable is referred before definition #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9aa1346
fix if statement logic and add zstd check
ax-ale Aug 5, 2022
83a1c2b
fix if statement logic and add zstd uncompress
ax-ale Aug 5, 2022
17450b4
fix imports
ax-ale Aug 5, 2022
5d7a3c7
avoid variable be used before definition
ax-ale Aug 5, 2022
ae5b33e
Merge branch 'master' into master
wbarnha Mar 10, 2024
d3a882d
Remove unused import from legacy_records.py
wbarnha Mar 26, 2024
349fdee
Merge branch 'master' into master
wbarnha Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions kafka/record/default_records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ def _assert_has_codec(self, compression_type: int) -> None:
checker, name = codecs.has_lz4, "lz4"
elif compression_type == self.CODEC_ZSTD:
checker, name = codecs.has_zstd, "zstd"
else:
checker, name = lambda: False, "Unknown"
if not checker():
raise UnsupportedCodecError(
f"Libraries for {name} compression codec not found")
Expand Down Expand Up @@ -525,6 +527,8 @@ def _maybe_compress(self) -> bool:
compressed = lz4_encode(data)
elif self._compression_type == self.CODEC_ZSTD:
compressed = zstd_encode(data)
else:
compressed = '' # unknown
compressed_size = len(compressed)
if len(data) <= compressed_size:
# We did not get any benefit from compression, lets send
Expand Down
13 changes: 11 additions & 2 deletions kafka/record/legacy_records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
from kafka.record.util import calc_crc32

from kafka.codec import (
gzip_encode, snappy_encode, lz4_encode, lz4_encode_old_kafka,
gzip_decode, snappy_decode, lz4_decode, lz4_decode_old_kafka,
gzip_encode, snappy_encode, lz4_encode, lz4_encode_old_kafka, zstd_encode,
gzip_decode, snappy_decode, lz4_decode, lz4_decode_old_kafka, zstd_decode
)
import kafka.codec as codecs
from kafka.errors import CorruptRecordException, UnsupportedCodecError
Expand Down Expand Up @@ -110,6 +110,7 @@ class LegacyRecordBase:
CODEC_GZIP = 0x01
CODEC_SNAPPY = 0x02
CODEC_LZ4 = 0x03
CODEC_ZSTD = 0x04
TIMESTAMP_TYPE_MASK = 0x08

LOG_APPEND_TIME = 1
Expand All @@ -124,6 +125,10 @@ def _assert_has_codec(self, compression_type: int) -> None:
checker, name = codecs.has_snappy, "snappy"
elif compression_type == self.CODEC_LZ4:
checker, name = codecs.has_lz4, "lz4"
elif compression_type == self.CODEC_ZSTD:
checker, name = codecs.has_zstd, "zstd"
else:
checker, name = lambda: False, "Unknown"
if not checker():
raise UnsupportedCodecError(
f"Libraries for {name} compression codec not found")
Expand Down Expand Up @@ -195,6 +200,10 @@ def _decompress(self, key_offset: int) -> bytes:
uncompressed = lz4_decode_old_kafka(data.tobytes())
else:
uncompressed = lz4_decode(data.tobytes())
elif compression_type == self.CODEC_ZSTD:
uncompressed = zstd_decode(data)
else:
raise ValueError("Unknown Compression Type - %s" % compression_type)
return uncompressed

def _read_header(self, pos: int) -> Union[Tuple[int, int, int, int, int, None], Tuple[int, int, int, int, int, int]]:
Expand Down
Loading