Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Project And Workspace Management #8389

Merged
merged 4 commits into from
Nov 30, 2021
Merged

add Project And Workspace Management #8389

merged 4 commits into from
Nov 30, 2021

Conversation

kyoobey
Copy link
Contributor

@kyoobey kyoobey commented Oct 8, 2021

I would like to submit a Sublime Text plugin Project Management for, as the name suggests, managing sublime project and workspace files

@kyoobey kyoobey changed the title added Project Management add Project Management Oct 9, 2021
@rchl
Copy link
Contributor

rchl commented Oct 10, 2021

I was going to say that https://github.com/randy3k/ProjectManager already exists but you explicitly say that:

This project was inspired by randy3k/ProjectManager

In that case, what makes your package different from the existing one? It would be quite confusing to have two seemingly identical packages that also bear almost the same name.

repository/p.json Outdated Show resolved Hide resolved
@kyoobey
Copy link
Contributor Author

kyoobey commented Oct 11, 2021

the existing plugin saves all sublime-projects files at a central location, making it difficult to manage all the files. This plugin saves them inside the project folders, and also adds the posibility for multiple workspaces for a single project without making extra sublime-project files

@rchl
Copy link
Contributor

rchl commented Oct 11, 2021

The decision whether to accept it or not is not up to me but if it were for me, I would at least require proper description in the readme that describes why would one want to use this over the other.

Also, while you mention the "extra" features that your package supports, it would be fair to also mention what it doesn't support. I believe that Project Manager is quite a bit more advanced one.

@kyoobey
Copy link
Contributor Author

kyoobey commented Oct 12, 2021

thanks for the feedback, i've added some information about the functionality in my readme file

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Project Management

Packages added:
  - Project Management

Processing package "Project Management"
  - All checks passed

@rchl
Copy link
Contributor

rchl commented Oct 25, 2021

One last comment since I still feel weird about adding this one. The reason I feel weird is because the name barely differs from the original Project Manager package so it feels like a bit shady practice of creating a similarly named product or domain to benefit from the popularity of the original.

And it also adds to confusion since there is no clear description of the differences between the two.

@kyoobey
Copy link
Contributor Author

kyoobey commented Oct 31, 2021

sorry for the late reply, I was busy with school work

I have changed the plugin name from Project Management to Project And Workspace Management. Hopefully this solves the issue.

Signed-off-by: tshrpl <tshrpl@protonmail.com>
@rwols
Copy link
Contributor

rwols commented Oct 31, 2021

I’d go further and suggest to make a pull request with your desired changes in the existing Project Management package.

@kyoobey kyoobey changed the title add Project Management add Project And Workspace Management Oct 31, 2021
@kyoobey
Copy link
Contributor Author

kyoobey commented Oct 31, 2021

I found an issue in the old plugin repository requesting the same features that i implement. It seems it's not possible to add these functionalities because the old plugin saves the project/workspace files in a centralized location, and my plugin saves them inside the project folder itself.

@rchl
Copy link
Contributor

rchl commented Nov 1, 2021

Can you explain why storing projects in a centralized location is not compatible with switching workspaces?

@randy3k was open to implementing that idea...

@braver braver added the duplicate This package has already been submitted/accepted in a different pull request label Nov 2, 2021
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Project And Workspace Management

Packages added:
  - Project And Workspace Management

Processing package "Project And Workspace Management"
  - All checks passed

@kyoobey
Copy link
Contributor Author

kyoobey commented Nov 5, 2021

Well, it is not exactly incompatible. Storing the project/workspace files inside each project gives users easy access to the files to save them in version control or create new build systems (like a visual studio solution file). in fact, someone already made a pull request in randy3k's repository, but the code changes were significant and they were unable to merge the pr.

@braver
Copy link
Collaborator

braver commented Nov 30, 2021

I can follow that. Some people like having their project files in one place, but it's just as common to store them in the project root dir. I would recommend really clearly communicating that difference in philosophy, because you're starting with ~60k installs less and it's not necessarily immediately clear why one would use your package over the other options. Other than that, your package looks good so let's ship it.

@braver braver merged commit b57f2c7 into wbond:master Nov 30, 2021
@jrappen
Copy link
Contributor

jrappen commented Nov 30, 2021

@tshrpl Your package is not compatible as stated here with "sublime_text": ">=3000". Please fix your package or fix this here with a new PR and a limit to ST4.

@kyoobey
Copy link
Contributor Author

kyoobey commented Dec 1, 2021

Hey thanks for pointing that out, I'm not sure why my package is not compatible with ST3 so for now I'm limiting it to ST4 and opened a pr for the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This package has already been submitted/accepted in a different pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants