-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Project And Workspace Management #8389
Conversation
I was going to say that https://github.com/randy3k/ProjectManager already exists but you explicitly say that:
In that case, what makes your package different from the existing one? It would be quite confusing to have two seemingly identical packages that also bear almost the same name. |
the existing plugin saves all sublime-projects files at a central location, making it difficult to manage all the files. This plugin saves them inside the project folders, and also adds the posibility for multiple workspaces for a single project without making extra sublime-project files |
The decision whether to accept it or not is not up to me but if it were for me, I would at least require proper description in the readme that describes why would one want to use this over the other. Also, while you mention the "extra" features that your package supports, it would be fair to also mention what it doesn't support. I believe that Project Manager is quite a bit more advanced one. |
thanks for the feedback, i've added some information about the functionality in my readme file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Project Management
Packages added:
- Project Management
Processing package "Project Management"
- All checks passed
One last comment since I still feel weird about adding this one. The reason I feel weird is because the name barely differs from the original And it also adds to confusion since there is no clear description of the differences between the two. |
sorry for the late reply, I was busy with school work I have changed the plugin name from |
Signed-off-by: tshrpl <tshrpl@protonmail.com>
I’d go further and suggest to make a pull request with your desired changes in the existing Project Management package. |
I found an issue in the old plugin repository requesting the same features that i implement. It seems it's not possible to add these functionalities because the old plugin saves the project/workspace files in a centralized location, and my plugin saves them inside the project folder itself. |
Can you explain why storing projects in a centralized location is not compatible with switching workspaces? @randy3k was open to implementing that idea... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Project And Workspace Management
Packages added:
- Project And Workspace Management
Processing package "Project And Workspace Management"
- All checks passed
Well, it is not exactly incompatible. Storing the project/workspace files inside each project gives users easy access to the files to save them in version control or create new build systems (like a visual studio solution file). in fact, someone already made a pull request in randy3k's repository, but the code changes were significant and they were unable to merge the pr. |
I can follow that. Some people like having their project files in one place, but it's just as common to store them in the project root dir. I would recommend really clearly communicating that difference in philosophy, because you're starting with ~60k installs less and it's not necessarily immediately clear why one would use your package over the other options. Other than that, your package looks good so let's ship it. |
@tshrpl Your package is not compatible as stated here with |
Hey thanks for pointing that out, I'm not sure why my package is not compatible with ST3 so for now I'm limiting it to ST4 and opened a pr for the same |
I would like to submit a Sublime Text plugin
Project Management
for, as the name suggests, managing sublime project and workspace files