Skip to content

Update of the specs for stdlib_sorting #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2021
Merged

Update of the specs for stdlib_sorting #3

merged 2 commits into from
May 30, 2021

Conversation

jvdp1
Copy link

@jvdp1 jvdp1 commented May 29, 2021

I quickly updated the specs for the added option reverse.
Note: I wonder if the algorithm ord_sort is still stable in reverse mode (see bold sentences in the specs)

@jvdp1 jvdp1 mentioned this pull request May 29, 2021
Merged
wclodius2
wclodius2 requested changes May 30, 2021
View reviewed changes
Copy link
Owner

@wclodius2 wclodius2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes if you consistently reverse the direction of the comparisons then ORD_SORT is still a stable comparison. The two questions on the stability of the algorithm should be removed.

@jvdp1
Copy link
Author

jvdp1 commented May 30, 2021 •
edited
Loading

Yes if you consistently reverse the direction of the comparisons then ORD_SORT is still a stable comparison. The two questions on the stability of the algorithm should be removed.

Thank you. I removed them with this commit

From my side, you can merge it if you are happy with the changes.

wclodius2
wclodius2 approved these changes May 30, 2021
View reviewed changes
Copy link
Owner

@wclodius2 wclodius2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

wclodius2
wclodius2 approved these changes May 30, 2021
View reviewed changes
Copy link
Owner

@wclodius2 wclodius2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@wclodius2 wclodius2 merged commit 1c6e985 into wclodius2:sorting2 May 30, 2021
wclodius2 pushed a commit that referenced this pull request Jun 20, 2021
@aman-godara
Merge pull request #3 from awvwgk/slice
a895085 
Add general tester against intrinsic array slice
wclodius2 pushed a commit that referenced this pull request Oct 19, 2021
@St-Maxwell
Merge pull request #3 from Aman-Godara/format_string
f155525 
renamed strings_format_string to string_format_string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wclodius2 wclodius2 wclodius2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvdp1 @wclodius2