Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1] Adds relative config path to ToolsConfigPagePersistenceStrategy configuration #2

Merged
merged 4 commits into from
Oct 13, 2023
Merged

[1] Adds relative config path to ToolsConfigPagePersistenceStrategy configuration #2

merged 4 commits into from
Oct 13, 2023

Conversation

cnagel
Copy link
Contributor

@cnagel cnagel commented Sep 20, 2023

Adds relative config path to ToolsConfigPagePersistenceStrategy configuration.

Fixes #1

stefanseifert
stefanseifert requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - can you also add a test case with a configured non-standard path?

...ain/java/io/wcm/caconfig/extensions/persistence/impl/ToolsConfigPagePersistenceStrategy.java Outdated Show resolved Hide resolved
@cnagel cnagel force-pushed the feature/tools-config-page-persistence-strategy-configure-relative-config-path branch from fac9409 to 9d0722b Compare October 13, 2023 10:58
@stefanseifert stefanseifert merged commit 18e3511 into wcm-io:develop Oct 13, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanseifert stefanseifert stefanseifert requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ToolsConfigPagePersistenceStrategy | make relative config path configurable
2 participants
@cnagel @stefanseifert