Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daniel - tweedr #112

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Daniel - tweedr #112

wants to merge 4 commits into from

Conversation

dannxt
Copy link

@dannxt dannxt commented Apr 23, 2020

Deliverable Submission

Please describe your comfort and completeness levels before submitting. Comfort Level (1-5):
3
Completeness Level (1-5):
2

How many hours did you spend on this assignment?
5
What part did you spend the most time on?
Understanding the MVC components and the callback functions

Does the assignment run without errors? If the assignment has errors, what are they?
Listing all tweet has a minor bug that needs to be fixed

Describe one part of the code or choose one line you would improve upon. What would you improve?

What did you think of this deliverable? Any other comments?
I realize theres a more elegant /newer way of doing callback functions using promises, fetch().then() etc. Wonder if this will be taught in class.

@dannxt
Copy link
Author

dannxt commented Apr 24, 2020

Deliverable Submission

Please describe your comfort and completeness levels before submitting. Comfort Level (1-5):
3

Completeness Level (1-5):
2

How many hours did you spend on this assignment?
6

What part did you spend the most time on?
Doing multiple queries; nested queries. Getting hashtags to show as checkboxes as intended.

Does the assignment run without errors? If the assignment has errors, what are they?
Tweeds and hashtag relationship tables arent finished.

Describe one part of the code or choose one line you would improve upon. What would you improve?

What did you think of this deliverable? Any other comments?
I'm not sure of when we should use script.js to change dom elements, in this particular assignment. Also, not sure how to import external style.css into jsx.

@dannxt
Copy link
Author

dannxt commented Apr 27, 2020

Deliverable Submission

Please describe your comfort and completeness levels before submitting. Comfort Level (1-5):
2

Completeness Level (1-5):
2

How many hours did you spend on this assignment?
5

What part did you spend the most time on?
understanding the ajax process, finding out arrow functions don't work well on methods since they use lexical scoping, reading up on syntax stuff

Does the assignment run without errors? If the assignment has errors, what are they?

Describe one part of the code or choose one line you would improve upon. What would you improve?

What did you think of this deliverable? Any other comments?
Good refresher on AJAX. I would like to know what other forms of data (images, etc) we can send using AJAX request and how that would necessitate a change in request.setRequestHeader and other areas of codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant