Skip to content

Conversation

@yukitsuboniwa
Copy link

No description provided.

@shumin13
Copy link

Glow

  • Good attempt on keeping track of high score
  • Good presentation skills
  • Good attempt on the commit messages

Grow & Things to look out for

  • Incorrect indentation
  • Mixing jquery ($('#player').css('visibility', 'visible')) with DOM manipulation (eg. document.getElementById('score'))
  • May want to inform users that there will only be one laser at any one time
  • Time management for presentation

@primaulia
Copy link
Contributor

Project Workflow: 4 / 5
Technical Requirement: 3 / 5
Creativity: 2 / 5
Problem Solving: 3 / 5
Delivery: 4 / 5
Professional Skill: 4 / 5

Glow

  • Great workflow, I love it that you're very succinct in your explanation and complemented with supporting codes. So it doesn't feel like you're just paraphrasing your codes
  • Good attempt on coming up with the slides. Though I feel you can engage your classmate more for this unit
  • I love that you're focus on your development process so you could finish early

Grow

  • I must say, the game is fun, but looking at your reference, I think you haven't modified much from the tutorial. Would be great if you could modify them even more
  • The usage of native dom manipulation is cool, technically it's the same like jQuery. However, I do think that we've covered more than enough for you to be able to modify your tutorial codes into jQuery
  • So please rewrite your code with jQuery for your meet and greet. I do think it'll be good to you to do that

Things to look out for

  • Go beyond tutorial, real problems require real solutions made by you
  • Proof that you really understand on how to make a proper javascript project from scratch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants