Zach - Submission - Recipe Keeper

[zachariah-chow]

Deliverable Submission

--Code-Reading--
Floobits link: https://floobits.com/zachariahz/sei22-floobits/browse/code-reading/recipe-keeper

Please describe your comfort and completeness levels before submitting.
Comfort Level (1-5): 4

Completeness Level (1-5): 3

How many hours did you spend on this assignment? Probably more than 6? Didn't keep proper count

What part did you spend the most time on? Implementing control methods for all the various assignment requirements.

Does the assignment run without errors? Yes, mostly. Did not test extensively for bugs though.
If the assignment has errors, what are they?

Describe one part of the code or choose one line you would improve upon.
What would you improve? Well for one the styling is quite poor, lack of media queries for larger viewports, images are poorly styled leading to some undesirable behaviour at some device widths/heights. Sorting should be more user friendly, should allow to sort by ascending/descending, and should also sort by more parameters. Have not implemented quite a few of the 'further' requirements. Unsure if use of external script files is against any best practices, could refactor script into existing jsx files. Should organise views folders and json files.

What did you think of this deliverable? Any other comments?

Pretty challenging, especially in relation to keeping track of the various parts of the file architecture once the code base starts to scale.

[ianshalom]

Zach's code is clean and coherent and applies to perfection the Model View Controller concept. It would be great if he could annotate/comment more on his code.

[chelsejw]

Zach's gone above and beyond by implementing the MVC framework for his application. Great naming conventions. He's structured it in such a way that every file/folder has a focus. It might be because we've not learnt MVC yet but it would be good to have some comments so that we could understand it better.