marker cluster sumatory of markers label #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goinnn
reviewed
Apr 28, 2022
www/MarkerCluster.js
Outdated
| var countCluster = 0; | ||
| cluster._markerArray.forEach(function (marker) { | ||
| var data = marker.get('data'); | ||
| if (data && data.data && data.data.operative == 'ECHARGE') { |
There was a problem hiding this comment.
Le pondria algo mas generico. Algo como
if (data && data.data && data.data.sumLabel) {
countCluster += data.data.label;
} else {
countCluster += 1;
}
Al meter el else ya no te hace falta el if de la linea 966
goinnn
reviewed
Apr 28, 2022
www/MarkerCluster.js
Outdated
| MarkerCluster.prototype.getClusterLabelData = function (self, data, key) { | ||
| var self = self; | ||
| var index = key.indexOf("."); | ||
| var firstPart = null; |
There was a problem hiding this comment.
Cambiar la manera de acceder por esta manera, con un comentario a este enlace:
Delete commented unused crossWalk code
Allow currentPageUrl ionic3 with only https:/localhost/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request guide
Thank you for considering to improve this cordova-plugin-googlemaps.
When you create a pull request, please make it to multiple_maps branch instead of master branch.
Because the multiple_maps branch is edge version.
Thank you for your understanding.