fix: replace usage of polyfill.io with cloudflare

[sapayth]

There is a security alert about the Polyfill issue. Details here

Summary by CodeRabbit

• Refactor
  • Optimized the script loading process by removing redundant code for checking and loading a Promise polyfill.

[coderabbitai]

Walkthrough

These changes involve the removal of a block of code in the Admin_Form_Builder class that was responsible for checking and loading a polyfill for Promise. This update simplifies the script loading process as modern browsers inherently support Promise, and it addresses a potential security risk with the external polyfill source.

Changes

Files	Change Summary
includes/Admin/Forms/Admin_Form_Builder.php	Removed code block responsible for checking and loading a polyfill for Promise in admin_print_scripts method.

Sequence Diagram(s)

Changes are too simple to require sequence diagrams.

Possibly related issues

• window.Promise polyfill #1462: This change removes the potentially untrustworthy cdn.polyfill.io script, addressing the security concern mentioned in the issue.

Poem

Gone the polyfill's day to check,
No more scripts from dubious tech.
Promises kept by browsers new,
Simpler code, and safer too.
Modern paths we now embrace,
Efficiency at a steady pace. 🚀

---

Tip

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues.
• OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

includes/Admin/Forms/Admin_Form_Builder.php (1)

[!TIP]
Codebase Verification

Potential Compatibility Issue with Older Browsers

The removal of the Promise polyfill might cause compatibility issues with older browsers that do not support native Promise. Several third-party libraries in the project, such as Vuex, Vue Router, Vue, and SweetAlert2, rely on Promise.

• Recommendation: Verify browser compatibility or consider reintroducing the polyfill conditionally to ensure support for older browsers.

• Files with Promise references:

  • assets/vendor/vuex/vuex.min.js
  • assets/vendor/vue-router/vue-router.js
  • assets/vendor/vue/vue.min.js
  • assets/vendor/sweetalert2/sweetalert2.js

Analysis chain

Line range hint 66-70: LGTM! Ensure compatibility with older browsers.

The removal of the polyfill for Promise addresses a security alert.

However, verify that this change does not affect compatibility with older browsers that do not support native Promises.

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the removal of the polyfill for `Promise` does not affect compatibility with older browsers.

# Test: Search for any remaining references to `Promise` polyfill. Expect: No references to `Promise` polyfill.
rg --type php $'Promise'

Length of output: 23

---

---

Script:

#!/bin/bash
# Description: Verify that the removal of the polyfill for `Promise` does not affect compatibility with older browsers.

# Test: Search for any usage of `Promise` in JavaScript files. Expect: No usage of `Promise` without polyfill.
rg --type js $'Promise'

Length of output: 145670

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 92a12ae and d238c56.

Files selected for processing (1)

• includes/Admin/Forms/Admin_Form_Builder.php (1 hunks)

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d238c56 and 7200deb.

Files selected for processing (1)

• includes/Admin/Forms/Admin_Form_Builder.php (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• includes/Admin/Forms/Admin_Form_Builder.php