Merge pull request #207 from tshedor/rails-5-depreciations

#167 - remove depreciation warnings in rails 5
wearefine · Apr 21, 2017 · c03c42f · c03c42f
2 parents 8a54955 + f19520d
commit c03c42f
Show file tree

Hide file tree

Showing 13 changed files with 63 additions and 99 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Unreleased
 
 - enhancements
+    + Resolve Rails 5 depreciation warnings [#167](https://github.com/wearefine/fae/issues/167)
     + Update dynamic relationships docs for pages and split out to make easier to find.
 - bugs
 

diff --git a/Gemfile b/Gemfile
@@ -20,18 +20,19 @@ gem 'carrierwave', '~> 0.10.0'
 gem 'rmagick', '~> 2.13.3', require: false
 
 group :test, :development do
-  gem 'rspec-rails', '~> 3.0.2'
+  gem 'rspec-rails', '~> 3.5.2'
   gem 'pry'
 end
 
 group :test do
   gem 'factory_girl_rails', '~> 4.4.1'
-  gem 'capybara-webkit', '~> 1.11.1'
+  gem 'capybara-webkit', '~> 1.14.0'
   gem 'capybara-screenshot'
   gem 'guard-rspec', '~> 4.3.1'
   gem 'selenium-webdriver', '~> 2.42.0'
   gem 'shoulda-matchers', require: false
   gem 'yarjuf'
+  gem 'rails-perftest', '~> 0.0.7'
   gem 'database_cleaner'
   gem 'rails-controller-testing'
 end

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -110,8 +110,8 @@ GEM
     capybara-screenshot (1.0.14)
       capybara (>= 1.0, < 3)
       launchy
-    capybara-webkit (1.11.1)
-      capybara (>= 2.3.0, < 2.8.0)
+    capybara-webkit (1.14.0)
+      capybara (>= 2.3.0, < 2.14.0)
       json
     carrierwave (0.10.0)
       activemodel (>= 3.2.0)
@@ -131,7 +131,7 @@ GEM
       railties (>= 4.1.0, < 5.1)
       responders
       warden (~> 1.2.3)
-    diff-lcs (1.2.5)
+    diff-lcs (1.3)
     erubis (2.7.0)
     eventmachine (1.2.0.1)
     execjs (2.7.0)
@@ -230,7 +230,7 @@ GEM
       nokogiri (~> 1.6.0)
     rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    rails-perftest (0.0.6)
+    rails-perftest (0.0.7)
     railties (5.0.0.1)
       actionpack (= 5.0.0.1)
       activesupport (= 5.0.0.1)
@@ -245,26 +245,27 @@ GEM
     responders (2.3.0)
       railties (>= 4.2.0, < 5.1)
     rmagick (2.13.4)
-    rspec (3.0.0)
-      rspec-core (~> 3.0.0)
-      rspec-expectations (~> 3.0.0)
-      rspec-mocks (~> 3.0.0)
-    rspec-core (3.0.4)
-      rspec-support (~> 3.0.0)
-    rspec-expectations (3.0.4)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.4)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.0.0)
-    rspec-mocks (3.0.4)
-      rspec-support (~> 3.0.0)
-    rspec-rails (3.0.2)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-rails (3.5.2)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       railties (>= 3.0)
-      rspec-core (~> 3.0.0)
-      rspec-expectations (~> 3.0.0)
-      rspec-mocks (~> 3.0.0)
-      rspec-support (~> 3.0.0)
-    rspec-support (3.0.4)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
     ruby-prof (0.16.2)
     ruby_dep (1.5.0)
     rubyzip (1.2.0)
@@ -335,7 +336,7 @@ DEPENDENCIES
   capistrano-rails!
   capistrano-rvm
   capybara-screenshot
-  capybara-webkit (~> 1.11.1)
+  capybara-webkit (~> 1.14.0)
   carrierwave (~> 0.10.0)
   database_cleaner
   factory_girl_rails (~> 4.4.1)
@@ -346,9 +347,9 @@ DEPENDENCIES
   mysql2
   pry
   rails-controller-testing
-  rails-perftest
+  rails-perftest (~> 0.0.7)
   rmagick (~> 2.13.3)
-  rspec-rails (~> 3.0.2)
+  rspec-rails (~> 3.5.2)
   ruby-prof
   sass
   selenium-webdriver (~> 2.42.0)
@@ -357,4 +358,4 @@ DEPENDENCIES
   yarjuf
 
 BUNDLED WITH
-   1.14.5
+   1.14.6
diff --git a/app/views/fae/shared/_form_header.html.slim b/app/views/fae/shared/_form_header.html.slim
@@ -32,5 +32,5 @@ ruby:
 - if subnav.present?
   ul.content-header-subnav#js-content-header-subnav
     - subnav.each do |link, id_selector|
-      - subnav_item = link.is_a?(Array) ? link : [link, link.parameterize('_')]
+      - subnav_item = link.is_a?(Array) ? link : [link, link.parameterize( separator: '_')]
       li: a href="##{subnav_item[1]}" = subnav_item[0]
diff --git a/docs/contributing/local_setup.md b/docs/contributing/local_setup.md
@@ -21,7 +21,7 @@ Cd to the dummy app:
 $ cd spec/dummy
 ```
 
-Create the DB if you haven't already and migrate:
+Create the DB if you haven't already and migrate (for Rails 5 >= substitute `rails` for `rake`):
 
 ```
 $ rake db:create:all

diff --git a/gemfiles/rails_4_1.gemfile b/gemfiles/rails_4_1.gemfile
@@ -12,24 +12,21 @@ gem "capistrano-rails", :git => "https://github.com/wearefine/rails"
 gem "capistrano-rvm"
 gem "mysql2"
 gem "rails", "~> 4.1.0"
-gem "remotipart", "~> 1.3.1"
 
 group :test, :development do
   gem "rspec-rails", "~> 3.0.2"
   gem "pry"
-  gem "quiet_assets"
 end
 
 group :test do
   gem "factory_girl_rails", "~> 4.4.1"
-  gem "capybara-webkit", "~> 1.8"
+  gem "capybara-webkit", "~> 1.11.1"
   gem "capybara-screenshot"
   gem "guard-rspec", "~> 4.3.1"
   gem "selenium-webdriver", "~> 2.42.0"
   gem "shoulda-matchers", :require => false
   gem "yarjuf"
-  gem "database_cleaner", "~> 1.3.0"
-  gem "capybara", "~> 2.4.1"
+  gem "database_cleaner"
 end
 
 gemspec :path => "../"
diff --git a/gemfiles/rails_4_1.gemfile.lock b/gemfiles/rails_4_1.gemfile.lock
@@ -7,7 +7,7 @@ GIT
       capistrano-bundler (~> 1.1)
 
 PATH
-  remote: ../
+  remote: ..
   specs:
     fae-rails (1.5.0)
       acts_as_list (~> 0.9.0)
@@ -94,8 +94,8 @@ GEM
     capybara-screenshot (1.0.9)
       capybara (>= 1.0, < 3)
       launchy
-    capybara-webkit (1.8.0)
-      capybara (>= 2.3.0, < 2.7.0)
+    capybara-webkit (1.11.1)
+      capybara (>= 2.3.0, < 2.8.0)
       json
     carrierwave (0.10.0)
       activemodel (>= 3.2.0)
@@ -185,8 +185,6 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
-    quiet_assets (1.1.0)
-      railties (>= 3.1, < 5.0)
     rack (1.5.5)
     rack-test (0.6.3)
       rack (>= 1.0)
@@ -301,22 +299,19 @@ DEPENDENCIES
   capistrano (~> 3.1)
   capistrano-rails!
   capistrano-rvm
-  capybara (~> 2.4.1)
   capybara-screenshot
-  capybara-webkit (~> 1.8)
+  capybara-webkit (~> 1.11.1)
   carrierwave (~> 0.10.0)
-  database_cleaner (~> 1.3.0)
+  database_cleaner
   factory_girl_rails (~> 4.4.1)
   fae-rails!
   guard-rspec (~> 4.3.1)
   jquery-rails
   jquery-ui-rails (~> 4.2.1)
   mysql2
   pry
-  quiet_assets
   rails (~> 4.1.0)
   rails-perftest
-  remotipart (~> 1.3.1)
   rmagick (~> 2.13.3)
   rspec-rails (~> 3.0.2)
   ruby-prof
@@ -327,4 +322,4 @@ DEPENDENCIES
   yarjuf
 
 BUNDLED WITH
-   1.13.0
+   1.14.6
diff --git a/gemfiles/rails_4_2.gemfile b/gemfiles/rails_4_2.gemfile
@@ -12,24 +12,21 @@ gem "capistrano-rails", :git => "https://github.com/wearefine/rails"
 gem "capistrano-rvm"
 gem "mysql2"
 gem "rails", "~> 4.2.0"
-gem "remotipart", "~> 1.3.1"
 
 group :test, :development do
   gem "rspec-rails", "~> 3.0.2"
   gem "pry"
-  gem "quiet_assets"
 end
 
 group :test do
   gem "factory_girl_rails", "~> 4.4.1"
-  gem "capybara-webkit", "~> 1.8"
+  gem "capybara-webkit", "~> 1.11.1"
   gem "capybara-screenshot"
   gem "guard-rspec", "~> 4.3.1"
   gem "selenium-webdriver", "~> 2.42.0"
   gem "shoulda-matchers", :require => false
   gem "yarjuf"
-  gem "database_cleaner", "~> 1.3.0"
-  gem "capybara", "~> 2.4.1"
+  gem "database_cleaner"
 end
 
 gemspec :path => "../"
diff --git a/gemfiles/rails_4_2.gemfile.lock b/gemfiles/rails_4_2.gemfile.lock
@@ -7,7 +7,7 @@ GIT
       capistrano-bundler (~> 1.1)
 
 PATH
-  remote: ../
+  remote: ..
   specs:
     fae-rails (1.5.0)
       acts_as_list (~> 0.9.0)
@@ -103,8 +103,8 @@ GEM
     capybara-screenshot (1.0.9)
       capybara (>= 1.0, < 3)
       launchy
-    capybara-webkit (1.8.0)
-      capybara (>= 2.3.0, < 2.7.0)
+    capybara-webkit (1.11.1)
+      capybara (>= 2.3.0, < 2.8.0)
       json
     carrierwave (0.10.0)
       activemodel (>= 3.2.0)
@@ -199,8 +199,6 @@ GEM
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
-    quiet_assets (1.1.0)
-      railties (>= 3.1, < 5.0)
     rack (1.6.4)
     rack-test (0.6.3)
       rack (>= 1.0)
@@ -324,22 +322,19 @@ DEPENDENCIES
   capistrano (~> 3.1)
   capistrano-rails!
   capistrano-rvm
-  capybara (~> 2.4.1)
   capybara-screenshot
-  capybara-webkit (~> 1.8)
+  capybara-webkit (~> 1.11.1)
   carrierwave (~> 0.10.0)
-  database_cleaner (~> 1.3.0)
+  database_cleaner
   factory_girl_rails (~> 4.4.1)
   fae-rails!
   guard-rspec (~> 4.3.1)
   jquery-rails
   jquery-ui-rails (~> 4.2.1)
   mysql2
   pry
-  quiet_assets
   rails (~> 4.2.0)
   rails-perftest
-  remotipart (~> 1.3.1)
   rmagick (~> 2.13.3)
   rspec-rails (~> 3.0.2)
   ruby-prof
@@ -350,4 +345,4 @@ DEPENDENCIES
   yarjuf
 
 BUNDLED WITH
-   1.13.0
+   1.14.6
diff --git a/gemfiles/rails_5_0.gemfile b/gemfiles/rails_5_0.gemfile
@@ -12,7 +12,6 @@ gem "capistrano-rails", :git => "https://github.com/wearefine/rails"
 gem "capistrano-rvm"
 gem "mysql2"
 gem "rails", "~> 5.0"
-gem "remotipart", "~> 1.3.1"
 
 group :test, :development do
   gem "rspec-rails", "~> 3.0.2"
@@ -21,15 +20,14 @@ end
 
 group :test do
   gem "factory_girl_rails", "~> 4.4.1"
-  gem "capybara-webkit"
+  gem "capybara-webkit", "~> 1.11.1"
   gem "capybara-screenshot"
   gem "guard-rspec", "~> 4.3.1"
   gem "selenium-webdriver", "~> 2.42.0"
   gem "shoulda-matchers", :require => false
   gem "yarjuf"
-  gem "database_cleaner", "~> 1.5.0"
-  gem "rails-controller-testing"
-  gem "capybara", :github => "jnicklas/capybara"
+  gem "database_cleaner"
+  gem 'rails-controller-testing'
 end
 
 gemspec :path => "../"