Add support for adding db indexes via fae:scaffold generator #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…command so you dont have to add another migration to add indexes after the fact
|
awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running
rails g fae:scaffold TestItem some_attribute:string:indexcauses the base generator to only generates the model and migration with the attribute name and type. This change gets the base generator to include and pass along the :index arg when generating a new model via the generate fae:scaffold task so you don't have to add another migration to add indexes after the fact.I'm using this change running the fae gem locally with my spec importer rake task and it's working great to create new models with the usual indexes for slug, position, on_prod/stage attrs included from the get go.